Skip to content

Revert "Add GlobalSecondaryIndexDefinition for GSI container support (#47468)"#48054

Closed
simorenoh wants to merge 1 commit into
mainfrom
simorenoh-revert-gsi-container-47468
Closed

Revert "Add GlobalSecondaryIndexDefinition for GSI container support (#47468)"#48054
simorenoh wants to merge 1 commit into
mainfrom
simorenoh-revert-gsi-container-47468

Conversation

@simorenoh

Copy link
Copy Markdown
Member

Description

This reverts PR #47468 ("Add GlobalSecondaryIndexDefinition for GSI container support").

The original PR was squash-merged as commit 8073e65288a68edf18b22c4a3932b89b9a5f383e. This PR reverts that single commit, restoring the azure-cosmos package to its prior state.

What this reverts

  • Removes the GlobalSecondaryIndexDefinition class (azure/cosmos/_global_secondary_index.py)
  • Removes the global_secondary_index_definition keyword from create_container, create_container_if_not_exists, and replace_container (sync and async)
  • Removes the associated unit and live tests
  • Reverts the GSI pipeline configuration (pytest.ini, tests.yml, live-platform-matrix.json)
  • Removes the GSI entries from CHANGELOG.md, api.md, and api.metadata.yml

Net: 2 insertions, 645 deletions across 12 files — a clean inverse of the original change. No dangling references to the removed symbols remain.

@simorenoh
simorenoh marked this pull request as ready for review July 14, 2026 20:38
@simorenoh
simorenoh requested a review from a team as a code owner July 14, 2026 20:38
Copilot AI review requested due to automatic review settings July 14, 2026 20:38
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 2 pipeline(s).
8 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

1 similar comment
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 2 pipeline(s).
8 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@simorenoh

Copy link
Copy Markdown
Member Author

/azp run python - cosmos - tests

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Reverts the unreleased Cosmos DB GSI container support, restoring the package to its pre-#47468 state.

Changes:

  • Removes the GSI API and sync/async integration.
  • Deletes GSI tests and pipeline configuration.
  • Restores changelog and API snapshots.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
sdk/cosmos/tests.yml Removes GSI credentials.
sdk/cosmos/live-platform-matrix.json Removes the GSI test matrix.
sdk/cosmos/azure-cosmos/tests/test_global_secondary_index.py Deletes GSI unit tests.
sdk/cosmos/azure-cosmos/tests/test_global_secondary_index_live.py Deletes GSI live tests.
sdk/cosmos/azure-cosmos/pytest.ini Removes the GSI marker.
sdk/cosmos/azure-cosmos/CHANGELOG.md Removes the unreleased feature entry.
sdk/cosmos/azure-cosmos/azure/cosmos/database.py Removes synchronous GSI parameters and serialization.
sdk/cosmos/azure-cosmos/azure/cosmos/aio/_database.py Removes asynchronous GSI support.
sdk/cosmos/azure-cosmos/azure/cosmos/_global_secondary_index.py Deletes the GSI definition class.
sdk/cosmos/azure-cosmos/azure/cosmos/__init__.py Removes the public GSI export.
sdk/cosmos/azure-cosmos/api.metadata.yml Updates the API snapshot hash.
sdk/cosmos/azure-cosmos/api.md Removes GSI API entries.

@simorenoh

Copy link
Copy Markdown
Member Author

don't merge this yet - trying to reconcile changes here first as the ideal scenario: #48038

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants