fix: apply --deploy-mode flags to adopted azure.yaml (#8923) by trangevi · Pull Request #8926 · Azure/azure-dev

trangevi · 2026-07-01T17:18:44Z

Why

When azd ai agent init -m <azure.yaml> routes to the unified Foundry adoption path, the --deploy-mode, --runtime, and --entry-point flags are silently ignored. The adopted azure.yaml is written as-is with no code_configuration applied to the agent service. This means users cannot select code deploy when adopting a sample.

Approach

After scaffoldProject succeeds, the new applyDeployModeToAdoptedProject function locates the azure.ai.agent service in the adopted project and applies deploy-mode configuration using the same promptDeployMode / promptCodeConfig functions the manifest path already uses.

Decision logic:

Explicit --deploy-mode flag -- always apply (user intent overrides sample)
No flag + service already has code_configuration or docker property -- no-op (respect pre-configured sample)
No flag + neither configured -- prompt interactively (or auto-select per noPrompt/userProvidedManifest rules)

For code deploy: writes code_configuration (runtime, entry_point, dependency_resolution) onto the service, updates language to python/csharp, clears any docker property.

For container deploy: sets the docker property (remoteBuild: true), updates language to docker, clears any code_configuration.

Testing

Added TestAdoptedServiceHasCodeConfig covering nil props, empty props, valid struct value, and null value cases
All existing adoption tests continue to pass
Full go test ./internal/cmd/... -short passes

Fixes: #8923

The unified azure.yaml adoption path (runInitFromAzureYaml) now processes --deploy-mode, --runtime, and --entry-point flags after scaffolding the project. For code deploy, code_configuration is written onto the agent service and the language is updated. For container deploy, the docker property is set. When no flags are provided and the service already has code_configuration or a docker property configured, the service is left unchanged (the sample's pre-configured state is respected). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

github-actions · 2026-07-01T17:18:57Z

📋 Prioritization Note

Thanks for the contribution! The linked issue isn't in the current milestone yet.
Thank you for logging this issue; our team is reviewing it. If you need urgent prioritization, tag @RickWinter and @kristenwomack to let us know.

Copilot

Pull request overview

This PR fixes #8923, where azd ai agent init -m <azure.yaml> (the unified Foundry adoption path added in #8885) silently ignored --deploy-mode, --runtime, and --entry-point. After the sample's azure.yaml is adopted, a new applyDeployModeToAdoptedProject hook locates the azure.ai.agent service and applies code- or container-deploy configuration, reusing the same promptDeployMode/promptCodeConfig helpers as the manifest path. Configuration is written back to the service via SetServiceConfigValue.

Changes:

Add applyDeployModeToAdoptedProject and the applyCodeDeployToService/applyContainerDeployToService/adoptedServiceHasCodeConfig helpers, invoked after scaffolding/provider stamping in runInitFromAzureYaml.
Resolve deploy mode with explicit-flag precedence, no-op when the sample is already configured, and prompt/auto-select otherwise; write code_configuration/docker/language onto the agent service.
Add TestAdoptedServiceHasCodeConfig covering nil/empty/struct/null property cases.

The core issue with this PR is a key-casing mismatch: the adopted path reads and writes snake_case (code_configuration, entry_point, dependency_resolution), but the unified azure.yaml inline agent shape and the extension's deploy/read path use camelCase (codeConfiguration, entryPoint, dependencyResolution, per schemas/azure.ai.agent.json and AgentDefinitionInline). Because SetServiceConfigValue writes the path verbatim into azure.yaml, the code configuration this PR writes will not be recognized at deploy time, so --deploy-mode code still has no effect — the bug the PR intends to fix. Detection of already-configured samples and the code→container clear path share the same casing problem, and language/runtime detection runs against . instead of the agent's source subdirectory.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.

File	Description
`cli/azd/extensions/azure.ai.agents/internal/cmd/init_adopt.go`	Adds the deploy-mode application hook and helpers for the adopted unified `azure.yaml`; uses snake_case config keys and `.` for language detection (both incorrect).
`cli/azd/extensions/azure.ai.agents/internal/cmd/init_adopt_test.go`	Adds `TestAdoptedServiceHasCodeConfig`, whose fixtures encode the same snake_case key as the code under test.

+	codeConfigMap := map[string]any{
+		"runtime":     codeConfig.Runtime,
+		"entry_point": codeConfig.EntryPoint,
+	}
+	if codeConfig.DependencyResolution != nil {
+		codeConfigMap["dependency_resolution"] = *codeConfig.DependencyResolution
+	}
+
+	codeConfigValue, err := structpb.NewValue(codeConfigMap)
+	if err != nil {
+		return fmt.Errorf("encoding code_configuration: %w", err)
+	}
+
+	if _, err := azdClient.Project().SetServiceConfigValue(ctx, &azdext.SetServiceConfigValueRequest{
+		ServiceName: serviceName,
+		Path:        "code_configuration",


+	if fields == nil {
+		return false
+	}
+	v, ok := fields["code_configuration"]


+	// Remove code_configuration if present (switching from code to container).
+	if _, err := azdClient.Project().SetServiceConfigValue(ctx, &azdext.SetServiceConfigValueRequest{
+		ServiceName: serviceName,
+		Path:        "code_configuration",


+	// The target directory (project root after adoption) is used for
+	// language detection.
+	targetDir := "."
+	showCodeDeploy := isPythonProject(targetDir) || isDotnetProject(targetDir)


+	for name, svc := range resp.GetProject().GetServices() {
+		if svc.GetHost() == AiAgentHost {
+			agentServiceName = name
+			agentSvc = svc
+			break
+		}
+	}


+				AdditionalProperties: &structpb.Struct{Fields: map[string]*structpb.Value{
+					"code_configuration": structpb.NewStructValue(&structpb.Struct{
+						Fields: map[string]*structpb.Value{
+							"runtime":     structpb.NewStringValue("python_3_13"),
+							"entry_point": structpb.NewStringValue("app.py"),
+						},
+					}),
+				}},


jongio

Two verified issues that affect correctness, plus a robustness concern:

1. Language detection uses project root instead of service directory (HIGH)

\ argetDir := "."\ means \isPythonProject/\isDotnetProject\ scan the project root, but adopted samples declare agent services in subdirectories (e.g., \project: ./agents/assistant). The manifest path uses the downloaded service directory (\init.go:1388). Here, \�gentSvc.GetRelativePath()\ should be used so auto-detection finds the correct files.

2. Non-deterministic map iteration picks an arbitrary service (MEDIUM)

esp.GetProject().GetServices()\ is a map. With multi-agent samples (researcher, writer, triage), the \�reak\ on line 559 applies configuration to whichever service the runtime iterates first. Either apply to all matching services or collect them and let the user choose.

3. Silently discarded \structpb.NewValue\ errors (LOW)

Lines 665 and 697 discard the error from \structpb.NewValue(language)\ with _. While unlikely to fail for string literals, ignoring errors deviates from the extension's error handling conventions.

Note on the existing bot comments about snake_case vs camelCase: those comments cite \internal/project/agent_definition.go\ and \AgentDefinitionInline, neither of which exist in the codebase. The agent_yaml struct uses YAML tag \code_configuration\ and the service target detection (\service_target_agent.go:1122) also reads \code_configuration. The PR's use of snake_case appears internally consistent. I'd recommend verifying which key the deploy path actually reads from the azure.yaml inline properties to confirm end-to-end correctness.

jongio · 2026-07-01T20:44:43Z

+	// The target directory (project root after adoption) is used for
+	// language detection.
+	targetDir := "."
+	showCodeDeploy := isPythonProject(targetDir) || isDotnetProject(targetDir)


targetDir := "." scans the project root, but the sample's agent code lives in the service subdirectory (e.g., ./agents/assistant). The manifest path at init.go:1388 passes the service's source directory to isPythonProject/isDotnetProject. Use agentSvc.GetRelativePath() here so language detection finds the correct files. Without this, showCodeDeploy will be false for most adopted samples, and promptCodeConfig will auto-detect the wrong runtime/entry-point.

jongio · 2026-07-01T20:44:43Z

+			agentSvc = svc
+			break
+		}
+	}


Map iteration order is non-deterministic in Go. If the adopted sample declares multiple azure.ai.agent services (e.g., researcher, writer, triage), this picks an arbitrary one and leaves the others unconfigured. Consider iterating all services and applying the deploy mode to each, or detecting the multi-service case and prompting the user.

jongio · 2026-07-01T20:44:43Z

+	}); err != nil {
+		return fmt.Errorf("updating service language to %s: %w", language, err)
+	}
+


Suggested change

langValue, err := structpb.NewValue(language)

if err != nil {

return fmt.Errorf("encoding language value: %%w", err)

}

jongio · 2026-07-01T20:45:51Z

Corrected review summary (the review body above has formatting issues from a shell escape bug):

Two verified issues that affect correctness, plus a robustness concern:

1. Language detection uses project root instead of service directory (HIGH)

targetDir := "." means isPythonProject/isDotnetProject scan the project root, but adopted samples declare agent services in subdirectories (e.g., project: ./agents/assistant). The manifest path uses the downloaded service directory (init.go:1388). Here, agentSvc.GetRelativePath() should be used so auto-detection finds the correct files.

2. Non-deterministic map iteration picks an arbitrary service (MEDIUM)

resp.GetProject().GetServices() is a map. With multi-agent samples (researcher, writer, triage), the break on line 559 applies configuration to whichever service the runtime iterates first. Either apply to all matching services or collect them and let the user choose.

3. Silently discarded structpb.NewValue errors (LOW)

Lines 665 and 697 discard the error from structpb.NewValue(language) with _. While unlikely to fail for string literals, ignoring errors deviates from the extension's error handling conventions.

Note on the existing bot comments about snake_case vs camelCase: those comments cite internal/project/agent_definition.go and AgentDefinitionInline, neither of which exist in the codebase. The agent_yaml struct uses YAML tag code_configuration and the service target detection (service_target_agent.go:1122) also reads code_configuration. The PR's use of snake_case appears internally consistent. I'd recommend verifying which key the deploy path actually reads from the azure.yaml inline properties to confirm end-to-end correctness.

Copilot AI review requested due to automatic review settings July 1, 2026 17:18

trangevi requested review from JeffreyCA, glharper, huimiu, hund030, therealjohn and trrwilson as code owners July 1, 2026 17:18

Copilot started reviewing on behalf of trangevi July 1, 2026 17:19 View session

microsoft-github-policy-service Bot assigned trangevi Jul 1, 2026

github-actions Bot added the ext-agents azure.ai.agents extension label Jul 1, 2026

Copilot AI reviewed Jul 1, 2026

View reviewed changes

jongio requested changes Jul 1, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: apply --deploy-mode flags to adopted azure.yaml (#8923)#8926

fix: apply --deploy-mode flags to adopted azure.yaml (#8923)#8926
trangevi wants to merge 1 commit into
mainfrom
trangevi/fix-8923-adopt-azure-yaml-deploy-mode

trangevi commented Jul 1, 2026

Uh oh!

github-actions Bot commented Jul 1, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

jongio left a comment

Uh oh!

jongio Jul 1, 2026 •

edited

Loading

Uh oh!

jongio Jul 1, 2026 •

edited

Loading

Uh oh!

jongio Jul 1, 2026 •

edited

Loading

Uh oh!

jongio commented Jul 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

+	langValue, err := structpb.NewValue(language)
+	if err != nil {
+		return fmt.Errorf("encoding language value: %%w", err)
+	}

Uh oh!

Conversation

trangevi commented Jul 1, 2026

Why

Approach

Testing

Uh oh!

github-actions Bot commented Jul 1, 2026

📋 Prioritization Note

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

jongio left a comment

Choose a reason for hiding this comment

Uh oh!

jongio Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jongio Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jongio Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jongio commented Jul 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jongio Jul 1, 2026 •

edited

Loading

jongio Jul 1, 2026 •

edited

Loading

jongio Jul 1, 2026 •

edited

Loading