fix(ci): build azure.ai.inspector from source in test workflow#8915
fix(ci): build azure.ai.inspector from source in test workflow#8915v1212 wants to merge 1 commit into
Conversation
The azure.ai.inspector extension was bumped to 1.0.0-beta.1 in source (#8896) but not yet published to the registry. The CI workflow was installing it from the registry, getting the old 0.0.1-preview version which doesn't satisfy azure.ai.agents' dependency constraint ~1.0.0-beta.1. Fix by building and installing azure.ai.inspector from source (same approach used for azure.ai.agents itself). Also add cli/azd/extensions/azure.ai.inspector/** to the workflow path trigger so inspector changes are tested. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes the test-ext-azure-ai-agents.yml CI workflow, which has been failing for all PRs touching the agents extension since the 1.0.0-beta.1 version bump (#8896). The agents extension depends on azure.ai.inspector ~1.0.0-beta.1, but only 0.0.1-preview of the inspector is published to the registry. The fix builds and installs the inspector from source (matching the existing approach used for azure.ai.agents itself) so the dependency constraint resolves locally.
Changes:
- Replaced the registry-based
azd extension install azure.ai.inspectorwith a dedicated step that builds the inspector from source viaci-build.ps1and installs it throughazd x pack/azd x publishfrom the local source. - Added
cli/azd/extensions/azure.ai.inspector/**to the workflow'spull_requestpath trigger so inspector source changes also exercise this test.
📋 Prioritization NoteThanks for the contribution! The linked issue isn't in the current milestone yet. |
RickWinter
left a comment
There was a problem hiding this comment.
This unblocks the agents extension test workflow by building azure.ai.inspector from source instead of pulling it from the registry, where only 0.0.1-preview exists against the new ~1.0.0-beta.1 constraint. The approach is the right shape: it mirrors the existing from-source build/pack/publish/install pattern used for azure.ai.agents in the same job, and the inspector version.txt (1.0.0-beta.1) satisfies the dependency constraint, so the resolution error goes away.
Nothing here blocks merge. One thing worth deciding explicitly rather than by accident: pairing the new azure.ai.inspector/** path trigger with a from-source build means inspector-only PRs now build and test their own inspector code, which is the behavior we want. If we ever revert to installing the published inspector, we reintroduce exactly this failure on the next version bump and stop testing PR inspector changes, so I'd keep the from-source build as the intended long-term state and adjust the comment to say so.
The redundant -Version argument and the --force on install are both consistent with the agents step directly below, so leaving them as-is is correct for readability parity. No security or correctness concerns in the diff.
| working-directory: cli/azd/extensions/azure.ai.inspector | ||
| run: | | ||
| # The azure.ai.inspector extension has not been published to the registry | ||
| # at 1.0.0-beta.1+ yet — build from source to satisfy the dependency. |
There was a problem hiding this comment.
Small wording point with a real intent behind it: the word "yet" reads as if this from-source build is a temporary workaround until inspector lands in the registry. Given we're now also triggering this workflow on azure.ai.inspector/** (the new path on line 7), building from source is actually the behavior we want to keep, since it tests each PR's own inspector code and avoids reintroducing this same resolution failure on the next version bump. Can we reword the comment to frame it as intentional (build inspector from source so the suite exercises PR changes) rather than a stopgap?
jongio
left a comment
There was a problem hiding this comment.
+1 on @RickWinter's inline: the comment on line 49 should frame building from source as the intended approach (it tests PR inspector changes and avoids future version-bump breakage), not a stopgap until the registry catches up. Minor wording fix, doesn't block merge.
Problem
All runs of
test-ext-azure-ai-agents.ymlare failing since the 1.0.0-beta.1 version bump (#8896):Root cause: The workflow installs
azure.ai.inspectorfrom the registry, but only0.0.1-previewhas been published there. The source was bumped to1.0.0-beta.1but never released to the registry.This blocks all PRs touching the agents extension (8 different branches affected today).
Fixes #8916
Fix
Build and install
azure.ai.inspectorfrom source usingci-build.ps1+azd x pack/publish-- the same approach already used forazure.ai.agentsitself.Also adds
cli/azd/extensions/azure.ai.inspector/**to the workflow path trigger so inspector source changes trigger the test.Verification
testjob passes on this PR