Harden go.mod loop against newline-containing paths in validate-go-version workflow#8907
Closed
Copilot wants to merge 2 commits into
Closed
Harden go.mod loop against newline-containing paths in validate-go-version workflow#8907Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Co-authored-by: mikeharder <9459391+mikeharder@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix code based on review comment
Harden go.mod loop against newline-containing paths in validate-go-version workflow
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review comment r3503331591 on PR #8906: the
for f in $(find ...)loop overgo.modfiles breaks if any matched path contains whitespace or a newline.Change
forloop with a null-delimitedfind -print0piped intowhile IFS= read -r -d ''in.github/workflows/validate-go-version.yml.Scope is limited to the go.mod loop called out in the linked comment; the other loops are left unchanged.