Skip to content

fix(vscode): Prompt for azure connector details and start design-time host on new projects#8607

Open
andrew-eldridge wants to merge 5 commits into
Azure:mainfrom
andrew-eldridge:aeldridge/newProjectDesignTimeFix
Open

fix(vscode): Prompt for azure connector details and start design-time host on new projects#8607
andrew-eldridge wants to merge 5 commits into
Azure:mainfrom
andrew-eldridge:aeldridge/newProjectDesignTimeFix

Conversation

@andrew-eldridge

@andrew-eldridge andrew-eldridge commented Nov 21, 2025

Copy link
Copy Markdown
Contributor

Fixes #6824

Commit Type

  • feature - New functionality
  • fix - Bug fix
  • refactor - Code restructuring without behavior change
  • perf - Performance improvement
  • docs - Documentation update
  • test - Test-related changes
  • chore - Maintenance/tooling

Risk Level

  • Low - Minor changes, limited scope
  • Medium - Moderate changes, some user impact
  • High - Major changes, significant user/system impact

What & Why

Adds the following initialization steps at end of 'Create new project' flow:

  • Prompts for azure connector details
  • Starts design-time host for the new project

Impact of Change

  • Users: Fixes incongruency between 'Create new workspace' and 'Create new project' where the latter doesn't immediately get azure connector details or start design-time
  • Developers: N/A
  • System: N/A

Test Plan

  • Unit tests added/updated
  • E2E tests added/updated
  • Manual testing completed
  • Tested in:

Contributors

@andrew-eldridge

@andrew-eldridge andrew-eldridge added the VSCode Issues or PRs specific to VS Code extension label Nov 21, 2025
Copilot AI review requested due to automatic review settings November 21, 2025 19:38
@andrew-eldridge andrew-eldridge added risk:low Low risk change with minimal impact bug Something isn't working labels Nov 21, 2025
@github-actions

github-actions Bot commented Nov 21, 2025

Copy link
Copy Markdown
Contributor

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

PR Title

  • Current: fix(vscode): Prompt for azure connector details and start design-time host on new projects
  • Issue: None — the title is specific, describes the user-facing behavior change, and includes an appropriate scope.
  • Recommendation: No change needed.

Commit Type

  • Properly selected (fix).
  • Only one commit type is checked, which is correct.

⚠️ Risk Level

  • The selected label/body risk is Low, which is reasonable for this scoped VS Code project initialization change.
  • The repository label also includes risk:low, so the body and label match.

What & Why

  • Current: Adds the following initialization steps at end of 'Create new project' flow: - Prompts for azure connector details - Starts design-time host for the new project
  • Issue: None — concise and clear.
  • Recommendation: No change needed.

Impact of Change

  • Impact is described clearly enough for the scope of the PR.
  • Recommendation:
    • Users: Good as written.
    • Developers: N/A is acceptable here.
    • System: N/A is acceptable here.

Test Plan

  • Unit tests were added/updated in the diff, which satisfies the test plan requirement.
  • Manual testing is also checked, which is fine.
  • No additional E2E tests are required since unit tests are present.

Contributors

  • Contributor attribution is present.
  • No action needed.

⚠️ Screenshots/Videos

  • No screenshots/videos are included.
  • This is acceptable because the change is functional rather than clearly visual.

Summary Table

Section Status Recommendation
Title No change needed
Commit Type No change needed
Risk Level No change needed
What & Why No change needed
Impact of Change No change needed
Test Plan No change needed
Contributors No change needed
Screenshots/Videos ⚠️ Optional for this non-visual change

This PR passes review for title/body compliance. The advised risk level is consistent with the submitter's low assessment.


Last updated: Wed, 01 Jul 2026 19:00:06 GMT

@github-actions

Copy link
Copy Markdown
Contributor

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

PR Title

  • Current: fix(vscode): Prompt for azure connector details and start design-time host on new projects
  • Issue: Title is specific, includes area affected, nature of fix, and scope
  • Recommendation: None needed. This is an ideal PR title.

Commit Type

  • Properly selected (fix)
  • Only one selected, which is correct

Risk Level

  • Risk level "Low" is selected. PR is labeled "Risk:Low", and based on the code change (small, targeted, 7 additions, no deletions, scope limited to initialization after project creation), this is appropriate.

What & Why

  • Current: Adds the following initialization steps at end of 'Create new project' flow:
  • Prompts for azure connector details
  • Starts design-time host for the new project
  • Issue: Clear, brief, describes what was changed and why (adds missing initialization step).
  • Recommendation: None needed.

Impact of Change

  • Clear indication of impact to users (addressing missing initialization after project creation), developers (N/A), and system (N/A).
  • Recommendation: Users: Clear
    • Developers: N/A, but could explicitly state if there are any expected developer-facing changes or workflow impact (optional)
    • System: N/A, but if system behavior changes (dependencies, broader impact), mention (optional)

Test Plan

  • "Manual testing completed" is checked, which is common for small workflow fixes. No unit/E2E test required for a simple UX fix.

Contributors

  • @andrew-eldridge listed
  • Minimal, but if more contributors (PM, Design) helped, tagging them is appreciated (optional)

Screenshots/Videos

  • Not needed for backend/initialization workflow change. Section left blank, this passes.

Summary Table

Section Status Recommendation
Title None
Commit Type None
Risk Level None
What & Why None
Impact of Change None
Test Plan None
Contributors Optional: Tag PMs/designers if they contributed
Screenshots/Videos None

The PR passes all body and title checks, and the risk level is correct. No changes required. Thank you for maintaining clear, concise documentation in your PR!


Last updated: Fri, 21 Nov 2025 19:38:41 GMT

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an inconsistency between the "Create new workspace" and "Create new project" flows by adding Azure connector details prompting and design-time host initialization to the project creation process. Previously, these initialization steps were only performed for workspace creation, leaving newly created projects without immediate Azure connector configuration or a running design-time API.

Key changes:

  • Added calls to getAzureConnectorDetailsForLocalProject() and startDesignTimeApi() at the end of the createLogicAppProject() function
  • Added a blank line formatting improvement in azureConnectorWizard.ts

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
apps/vs-code-designer/src/app/commands/workflows/azureConnectorWizard.ts Minor formatting change - added blank line after function definition
apps/vs-code-designer/src/app/commands/createNewCodeProject/CodeProjectBase/CreateLogicAppProjects.ts Added Azure connector details prompting and design-time API initialization calls after project creation, with necessary imports

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working pr-validated risk:low Low risk change with minimal impact VSCode Issues or PRs specific to VS Code extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Options like "host.json" and "local.settings.json" under workflow_designtime are not appearing as expected.

4 participants