load feature flags from new endpoint#341
Open
linglingye001 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for loading feature flags from new endpoint (via
FeatureFlagClient.listFeatureFlags), in addition to the classic key-value path. When feature flags are enabled, the provider now loads flags from both sources and merges them, with flags from the new endpoint taking precedence over classic ones of the same name. Reference Azure/AppConfiguration-DotnetProvider#738Key changes
Added
appConfigClient.ts: anIAppConfigurationClientinterface plusAppConfigClientimplementation that wraps bothAppConfigurationClient(classic KV) andFeatureFlagClient(new FF endpoint). Each method applies request tracing before delegating to the underlying SDK client.Added
featureFlagConverter.tswithconvertToMicrosoftSchema(), which maps the SDK's typedFeatureFlag(camelCase) into the Microsoft Feature Management schema consumed byfeature_management.feature_flags.Load and merge on init and on refresh:
#loadClassicFeatureFlags()+#loadFeatureFlags() →#setFeatureFlags()dedups by name (new endpoint supersedes classic).Change detection covers both paths