fix: stop building deprecated flatcar images, freeze to 0619#8833
Open
awesomenix wants to merge 1 commit into
Open
fix: stop building deprecated flatcar images, freeze to 0619#8833awesomenix wants to merge 1 commit into
awesomenix wants to merge 1 commit into
Conversation
awesomenix
requested review from
AbelHu,
Devinwong,
SriHarsha001,
calvin197,
cameronmeissner,
djsly,
ganeshkumarashok,
lilypan26,
mxj220,
pdamianov-dev,
phealy,
r2k1,
runzhen,
sulixu,
surajssd,
timmy-wright,
xuexu6666 and
zachary-bailey
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Stops building deprecated Flatcar VHD images (amd64/arm64) to avoid continued pipeline resource usage, while freezing Flatcar SIG image selection to a specific last-known version.
Changes:
- Removes Flatcar Packer templates and associated make/pipeline build paths.
- Removes Flatcar E2E scenarios and VHD config entries.
- Freezes Flatcar SIG image version to
202606.19.0in datamodel configuration.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
vhdbuilder/packer/vhd-image-builder-flatcar.json |
Removed Flatcar (amd64) Packer template. |
vhdbuilder/packer/vhd-image-builder-flatcar-arm64.json |
Removed Flatcar (arm64) Packer template. |
pkg/agent/datamodel/sig_config.go |
Introduces a frozen Flatcar SIG image version and applies it to Flatcar SIG templates. |
packer.mk |
Removes Flatcar build selection and Flatcar customdata generation target. |
e2e/scenario_test.go |
Removes Flatcar E2E scenario coverage. |
e2e/node_config.go |
Removes Flatcar SIG gallery config entries from E2E node config templates. |
e2e/config/vhd.go |
Removes Flatcar VHD definitions from E2E config. |
.pipelines/.vsts-vhd-builder-release.yaml |
Removes Flatcar build parameters and build jobs from the release pipeline. |
Comment on lines
+405
to
+406
| // Flatcar is deprecated on June 8th | ||
| FrozenFlatcarSIGImageVersion string = "202606.19.0" |
awesomenix
force-pushed
the
nishp/deprecateflatcar
branch
from
1e0afe4 to
5beafcf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flatcar is deprecated, stop building and wasting resources
Azure/AKS#5648