test: add e2e validation for MANA accelerated networking#8832
Draft
titilambert wants to merge 8 commits into
Draft
test: add e2e validation for MANA accelerated networking#8832titilambert wants to merge 8 commits into
titilambert wants to merge 8 commits into
Conversation
Author
|
This change is part of the following stack: Change managed by git-spice. |
Author
|
@microsoft-github-policy-service agree company="Microsoft" |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds end-to-end validation for MANA (Microsoft Azure Network Adapter) accelerated networking on newer VM series, expanding the e2e suite to assert both device/driver presence and datapath correctness on Ubuntu 22.04/24.04 and Azure Linux V3.
Changes:
- Added VMSS helper to explicitly enable Accelerated Networking on the primary NIC for targeted MANA scenarios.
- Introduced MANA validation helpers (PCI device, driver availability, VF bonding, VF traffic counters) and conditionally ran them from
ValidateCommonLinuxwhen MANA hardware is detected. - Added dedicated e2e scenarios for Ubuntu 22.04, Ubuntu 24.04, and Azure Linux V3 on a V6 SKU, plus a new
Tags.MANAfilter flag.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| e2e/vmss.go | Adds a helper to enable Accelerated Networking on the VMSS primary NIC. |
| e2e/validators.go | Implements MANA detection and validation steps (PCI/driver/VF bonding/traffic). |
| e2e/validation.go | Conditionally runs MANA validation as part of common Linux validations when hardware is detected. |
| e2e/types.go | Adds a MANA tag to scenario filtering. |
| e2e/scenario_test.go | Adds three VM-series coverage scenarios validating MANA on V6 SKUs across OSes. |
Comment on lines
+2904
to
+2907
| func hasMANAHardware(ctx context.Context, s *Scenario) bool { | ||
| result := execScriptOnVMForScenario(ctx, s, "lspci 2>/dev/null | grep -q '00ba'") | ||
| return result.exitCode == "0" | ||
| } |
Comment on lines
+2902
to
+2908
| // hasMANAHardware checks if the VM has MANA PCI hardware available. | ||
| // Returns true if the MANA device (00ba) is found in lspci output. | ||
| // This is used to conditionally run MANA validations on VMs that support it. | ||
| func hasMANAHardware(ctx context.Context, s *Scenario) bool { | ||
| result := execScriptOnVMForScenario(ctx, s, "lspci 2>/dev/null | grep -q '00ba'") | ||
| return result.exitCode == "0" | ||
| } |
Comment on lines
+2905
to
+2906
| result := execScriptOnVMForScenario(ctx, s, "lspci 2>/dev/null | grep -q '00ba'") | ||
| return result.exitCode == "0" |
Comment on lines
+2833
to
+2835
| cmd := `grep -q '/mana' /lib/modules/$(uname -r)/modules.builtin 2>/dev/null || find /lib/modules/$(uname -r)/kernel -name 'mana*.ko*' 2>/dev/null | grep -q .` | ||
| execScriptOnVMForScenarioValidateExitCode(ctx, s, cmd, 0, | ||
| "MANA kernel driver (mana.ko) not found as built-in or loadable module") |
Comment on lines
+2872
to
+2875
| // Send a known number of ICMP packets from a pod on this node | ||
| pingCmd := fmt.Sprintf("ping -c %d -W 2 168.63.129.16", pingCount) | ||
| pingResult := execOnVMForScenarioOnUnprivilegedPod(ctx, s, pingCmd) | ||
| require.Equalf(s.T, "0", pingResult.exitCode, "failed to execute ping from debug pod (exit %s):\n%s", pingResult.exitCode, pingResult.String()) |
| defer toolkit.LogStep(s.T, "validating traffic is flowing through MANA VF")() | ||
|
|
||
| const pingCount = 10 | ||
| getVFRxPackets := "sudo ethtool -S eth0 | awk -F': *' '/^[[:space:]]*vf_rx_packets:/{print $2; exit}'" |
Comment on lines
+2905
to
+2906
| result := execScriptOnVMForScenario(ctx, s, "lspci 2>/dev/null | grep -q '00ba'") | ||
| return result.exitCode == "0" |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
titilambert
force-pushed
the
add-e2e-tests-for-mana
branch
from
81bb13d to
294a4f3
Compare
Comment on lines
+2901
to
+2907
| // hasMANAHardware checks if the VM has MANA PCI hardware available. | ||
| // Returns true if the MANA device (00ba) is found in lspci output. | ||
| // This is used to conditionally run MANA validations on VMs that support it. | ||
| func hasMANAHardware(ctx context.Context, s *Scenario) bool { | ||
| result := execScriptOnVMForScenario(ctx, s, "lspci 2>/dev/null | grep -q '00ba'") | ||
| return result.exitCode == "0" | ||
| } |
| defer toolkit.LogStep(s.T, "validating traffic is flowing through MANA VF")() | ||
|
|
||
| const pingCount = 10 | ||
| getVFRxPackets := "sudo ethtool -S eth0 | awk -F': *' '/^[[:space:]]*vf_rx_packets:/{print $2; exit}'" |
Comment on lines
+2820
to
+2822
| cmd := `command -v lspci >/dev/null 2>&1 || { echo "lspci not found (install pciutils)"; exit 127; } | ||
| lspci | grep -i 'Microsoft Corporation'` | ||
| result := execScriptOnVMForScenarioValidateExitCode(ctx, s, cmd, 0, |
Comment on lines
+3333
to
+3335
| Validator: func(ctx context.Context, s *Scenario) { | ||
| ValidateMANA(ctx, s) | ||
| }, |
Comment on lines
+2873
to
+2888
| // Send a known number of ICMP packets from a pod on this node | ||
| pingCmd := fmt.Sprintf("ping -c %d -W 2 168.63.129.16", pingCount) | ||
| pingResult := execOnVMForScenarioOnUnprivilegedPod(ctx, s, pingCmd) | ||
| require.Equalf(s.T, "0", pingResult.exitCode, "failed to execute ping from debug pod (exit %s):\n%s", pingResult.exitCode, pingResult.String()) | ||
|
|
||
| // Read VF rx counter after generating traffic | ||
| resultAfter := execScriptOnVMForScenarioValidateExitCode(ctx, s, getVFRxPackets, 0, | ||
| "could not read VF rx packet counter from ethtool -S eth0") | ||
| countAfter, err := strconv.Atoi(strings.TrimSpace(resultAfter.stdout)) | ||
| require.NoError(s.T, err, "failed to parse vf_rx_packets after value %q", resultAfter.stdout) | ||
|
|
||
| delta := countAfter - countBefore | ||
| s.T.Logf("MANA VF rx packets after: %d (delta: %d, expected >= %d)", countAfter, delta, pingCount) | ||
|
|
||
| require.GreaterOrEqual(s.T, delta, pingCount, | ||
| "vf_rx_packets increased by %d but expected at least %d \u2014 traffic may not be flowing through the MANA VF", delta, pingCount) |
Signed-off-by: Thibault Cohen <thicohen@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds end-to-end tests validating that MANA (Microsoft Azure Network Adapter)
accelerated networking is properly configured on V6 VM series. The tests cover
Ubuntu 22.04, Ubuntu 24.04, and Azure Linux V3.
Validations added:
Additionally, MANA validation is run conditionally in
ValidateCommonLinuxon any VM where MANA hardware is detected (V5+ series).
Which issue(s) this PR fixes:
Fixes #