Acknowledge RP-applied Machine labels and taints - #278
Open
Wenxuan W (wenxuan0923) wants to merge 7 commits into
Open
Acknowledge RP-applied Machine labels and taints#278Wenxuan W (wenxuan0923) wants to merge 7 commits into
Wenxuan W (wenxuan0923) wants to merge 7 commits into
Conversation
Wenxuan W (wenxuan0923)
force-pushed
the
wenx/authoritative-machine-goals
branch
from
August 19, 2026 01:38
b25cacf to
f73a18c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Behavior
When the Machine ETag changes, the daemon compares the desired goal with its complete applied goal. It acknowledges in place only when:
Otherwise, the daemon continues returning
WaitForNodeSignaland requires the existing Node-deletion signal before blue-green repave.Direct ARM Machine status is currently read-only, so ARM mode persists local convergence while skipping the status mutation.
Validation
go test ./...go test -race ./pkg/daemongo vet ./...golangci-lint run --timeout=5m(0 issues)eastus2euapagainst RP frontendv20260807.260816.1:AcknowledgeGoalStateand advanced the applied ETag without changing Node UID, active nspawn side, or leader PID.WaitForNodeSignal, then repavedkube1tokube2only after Node deletion.v1.36.3; all test resources were deleted.