Decouple marble-kit from PNPM dependencies list to simplify flake.nix. - #5
Draft
Ezjfc wants to merge 5 commits into
Draft
Decouple marble-kit from PNPM dependencies list to simplify flake.nix.#5Ezjfc wants to merge 5 commits into
Ezjfc wants to merge 5 commits into
Conversation
Author
|
Note that this section will become obsolete but I am unsure of the appropriate changes for it: Lines 106 to 124 in 216a40a |
Author
|
Unfortunately, updating nixpkgs to the latest results in this error: Currently, I have no clue what went wrong. |
Author
|
This fix in the Marble Kit should resovle the above error: https://github.com/marble-shell/kit/issues/6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Previously, the sponsor-only dependency marble-kit must be fetched with an extended PNPM fetcher:
marble-shell/flake.nix
Lines 47 to 53 in 216a40a
Not only is this cumbersome, defeating the point of the identical
inputs.marble, but it also requires adding the SSH key to/nix/store, which is substantially insecure, as stated in README.md of agenix.This pull request makes a copy of the dependencies list (nix/package.json and nix/pnpm-lock.yaml) and sets
marbleto point to /nix/kit, which is populated withinputs.marbleduring build time.Extra
The PNPM fetcher (version 2) is also outdated and has been removed from 26.11. Attempts to change the fetcher version were tested to be unsuccessful, such as
which will always result in
Therefore, this pull request also updates
inputs.nixpkgsalongside the code of the fetcher.Moreover,
pkgs.pnpm.configHookis deprecated in favour ofpkgs.pnpmConfigHook:Lastly,
inputs.sshKeyis removed as it is no longer used by the flake.