APIGOV-33307 - enhancements to metrics collection and publishing - #1070
Merged
Conversation
jcollins-axway
commented
Jul 29, 2026
Collaborator
- Create benchmark for before and after changes
- Update benchmark markdown as changes are made
- Store metrics in cache by information provided during metric report
- Correlate the metric to the marketplace context when creating the metric for Engage
- On startup read the existing stored metrics as well as the new stored metric structure
- Remove use of go-metrics and replace with our own metric implementations
- Metrics only store and update count, min, max and total durations. Calculating average at publish time
- Read all metrics from registry, removing previously used metrics map
- Clean registry keys at publish time as each metric key will include timestamp for when observation period starts
- Lock on metric collector creation to avoid overwrite of global metric collector or panics writing to same object
jcollins-axway
requested review from
alrosca,
dfeldick,
dgghinea,
sbolosan and
vivekschauhan
as code owners
July 29, 2026 20:48
dgghinea
approved these changes
Jul 30, 2026
vivekschauhan
approved these changes
Jul 30, 2026
sbolosan
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.