Fix/vacation calendar user links#384
Merged
Merged
Conversation
added 3 commits
July 23, 2026 10:07
…ta.name Users are now matched by spec.profile.email (case-insensitive) instead of comparing metadata.name to the email local part. Links use EntityRefLink for correct catalog URLs. Unresolved users render without a link instead of navigating to /user/undefined. Dev fixtures updated to use full email scheduleIds and mount entityRouteRef so EntityRefLink works in the dev sandbox.
…p map Catalog fetches now use cursor-paginated queryEntities to support groups with 500+ users. User-by-email resolution uses a Map for O(1) lookups instead of scanning the user list per schedule entry.
🦋 Changeset detectedLatest commit: 3d6ee8d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
fridajac
enabled auto-merge (squash)
July 23, 2026 08:39
MartinWallgren
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
Fixes broken catalog links in the vacation calendar.
Users are now matched against
spec.profile.emailinstead ofmetadata.name, which prevents links such as/catalog/default/user/undefined. Resolved users use BackstageEntityRefLink, while users that cannot be resolved remain visible without a broken link.The catalog lookup is also cursor-paginated for large groups, and email lookups use a map to avoid repeated searches.
Context
Microsoft Graph returns a user's email as
scheduleId, but many Backstage catalogs use an LDAP-style username formetadata.name.Checklist before requesting a review
Verification
http://localhost:3001