fix(vacation-calendar): fix broken timeline layout#382
Merged
Conversation
🦋 Changeset detectedLatest commit: 0b16e07 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
fridajac
enabled auto-merge (squash)
July 20, 2026 12:16
MartinWallgren
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix broken timeline layout in consuming apps.
The
react-calendar-timelinepackage declaressideEffects: falsewith no exception for CSS, so its basestylesheet was tree-shaken out of the bundle when this plugin was consumed by
a host app (it only appeared to work in this plugin's own dev server, which
does not tree-shake). The base timeline styles are now inlined into this
plugin's own CSS file, and the
sideEffectsfield is updated to also coverthe compiled
*.css.esm.jsoutput so it survives bundling.