Skip to content

Keep multi-child hero stacks grouped#489

Merged
chubes4 merged 1 commit into
trunkfrom
fix-486-c1-style-materialization
Jul 4, 2026
Merged

Keep multi-child hero stacks grouped#489
chubes4 merged 1 commit into
trunkfrom
fix-486-c1-style-materialization

Conversation

@chubes4

@chubes4 chubes4 commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Tightens ColumnsPattern so split-layout heuristics only emit core/columns for actual two-pane structures.
  • Keeps multi-child content stacks such as .hero-content as core/group with the source class preserved, allowing the authored stylesheet to control flow.
  • Adds regression coverage for the seafood-style hero content stack.

Evidence

  • Issue: Closes C1 visual parity: style materialization gap — 97-100% native fixtures render 76-89% wrong (12-portfolio, 21-seafood-popup) #486
  • Baseline c1 ratios from SSI matrix (8421204 / transformer ebc3997): 12-portfolio 0.889, 21-studio-web-seafood-popup 0.759.
  • Single-fixture proof with this branch and current wp-codebox main:
    • 12-portfolio: 0.087 visual mismatch, native 0.966, fallback 0.035.
    • 21-studio-web-seafood-popup: 0.120 visual mismatch, native 1.000, fallback 0.000.
  • Full c1 proof completed with 7/7 fixtures passing hard gate. The zero-threshold pixel ratios remain unstable for subtle full-page background/text differences (e.g. visually aligned seafood screenshots report high ratios in multi-fixture runs), so the PR is intentionally scoped to the concrete generic layout misclassification fixed here.

Tests

  • php php-transformer/tests/unit/block-style-support-conversion.php
  • php php-transformer/tests/unit/corpus-detectors.php
  • php php-transformer/tests/contract/run.php
  • Direct SSI single-fixture matrix runs for 12-portfolio and 21-studio-web-seafood-popup passed.
  • Direct SSI c1 matrix run with --max-complexity 1 passed 7/7 hard gate.

AI assistance

  • AI assistance: Yes
  • Tool(s): GPT-5.5 via opencode subagent, orchestrated by Claude (claude-fable-5)
  • Used for: Diagnosis, implementation, tests, and PR drafting; reviewed by Chris Huber

@chubes4 chubes4 merged commit 86fe805 into trunk Jul 4, 2026
1 check passed
@chubes4 chubes4 deleted the fix-486-c1-style-materialization branch July 4, 2026 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

C1 visual parity: style materialization gap — 97-100% native fixtures render 76-89% wrong (12-portfolio, 21-seafood-popup)

1 participant