Fix unresolved imports from krun_sys in muvm binary#237
Closed
MR-UNKNOWN74IDK wants to merge 4 commits into
Closed
Fix unresolved imports from krun_sys in muvm binary#237MR-UNKNOWN74IDK wants to merge 4 commits into
MR-UNKNOWN74IDK wants to merge 4 commits into
Conversation
Update copyright year and owner in LICENSE file Signed-off-by: MR_UNKNOWN74IDK <236201746+MR-UNKNOWN74IDK@users.noreply.github.com>
Updated copyright holder to "The Asahi Linux Contributors". Signed-off-by: MR_UNKNOWN74IDK <236201746+MR-UNKNOWN74IDK@users.noreply.github.com>
Remove unresolved imports and function calls that no longer exist in the krun_sys bindings. - Remove `krun_set_root` from the krun_sys imports - Remove the `krun_set_root()` function call that sets the root path The `krun_set_root` function is no longer available in the current version of krun_sys. The root path configuration may now be handled by a different mechanism or is no longer necessary. Fixes compilation error: error[E0432]: unresolved imports `krun_sys::krun_set_root` Signed-off-by: MR_UNKNOWN74IDK <236201746+MR-UNKNOWN74IDK@users.noreply.github.com>
Reverted some information in the license file that already have one PR (PR AsahiLinux#235) for them and are not meant to be in this PR Signed-off-by: MR_UNKNOWN74IDK <236201746+MR-UNKNOWN74IDK@users.noreply.github.com>
MR-UNKNOWN74IDK
requested review from
WhatAmISupposedToPutHere,
alyssarosenzweig,
slp and
teohhanhui
as code owners
Member
|
#234 already fixes it in a different way. |
Author
|
So, what shall I do ? |
Member
|
Just abandon/close this PR, and use the stable branch of libkrun for your local development |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unresolved imports and function calls that no longer exist in
the krun_sys bindings.
krun_set_rootfrom the krun_sys importskrun_set_root()function call that sets the root pathThe
krun_set_rootfunction is no longer available in the currentversion of krun_sys. The root path configuration may now be handled
by a different mechanism or is no longer necessary.
Fixes compilation error:
error[E0432]: unresolved imports
krun_sys::krun_set_root