PIDReview: add D_FF PID parameter and data#329
Conversation
Also adds a prominent notice at the top of the page reminding users that the PID bit of LOG_BITMASK must be enabled for any PID log messages to be present in the log. Adds documentation and a signalflow graph
|
|
||
| <body> | ||
|
|
||
| <table><tr><td style="width:1200px"> |
There was a problem hiding this comment.
I don't think you need the table here, just apply the width limit to the paragraph.
| <body> | ||
|
|
||
| <table><tr><td style="width:1200px"> | ||
| <p style="text-align:center; background-color:#fff3cd; border:1px solid #ffc107; padding:10px; border-radius:4px;"> |
There was a problem hiding this comment.
I'm not a fan of style here, better to keep it consistent with the other tools. (Or update the others and this in a future PR).
| In <i>Mission Planner</i> this is found under <i>CONFIG > Full Parameter List</i>. | ||
| In <i>ArduPilot methodic configurator</i> this is done automatically when <a href="https://ardupilot.github.io/MethodicConfigurator/TUNING_GUIDE_ArduCopter#842-pid-notch-tuning">tuning the PID notch filters</a>. | ||
| Without this bit set, no PID log messages will be present in the log and this tool will show no data. | ||
| Here are <a href="https://github.com/ArduPilot/WebTools/blob/main/PIDReview/Readme.md">more details about this tool and how to use it</a>. |
There was a problem hiding this comment.
I'm not a fan of calling out what to do in a particular GCS. I would rather keep it to the ArduPilot configuration parameters. Or link to a wiki page what gives more detail.
There was a problem hiding this comment.
For me on chrome the fieldset needs more width to fit the new button.
| Notch_target: prefix + "NTF", | ||
| Error_filter: prefix + "FLTE", | ||
| Notch_error: prefix + "NEF", |
There was a problem hiding this comment.
Was the intention to add the notch stuff in this PR?
There was a problem hiding this comment.
Yes, that is just info that was missing before
| The **PID** bit of the `LOG_BITMASK` parameter must be set before flying so that PID log messages (`PIDR`, `PIDP`, `PIDY`, `PIQR`, `PIQP`, `PIQY`, `PIDS`, `PIDA`) are recorded. | ||
| Without this the tool will find no data. |
There was a problem hiding this comment.
The D low pass filter is done after the differentiation.
|
|
||
| ## How to use | ||
|
|
||
| 1. Open the tool in a browser and load a `.bin` log file using the file picker or the **Open In** button (when launched from a GCS). |
There was a problem hiding this comment.
" or the Open In button (when launched from a GCS)."?
| ### Frequency Domain (FFT) | ||
|
|
||
| Averaged windowed FFT of the selected PID signals over the chosen time range. | ||
| Each signal (Target, Actual, Error, P, I, D, FF, Output) can be shown or hidden independently. |
2 participants
Also adds a prominent notice at the top of the page reminding users that the PID bit of LOG_BITMASK must be enabled for any PID log messages to be present in the log.
Adds documentation and a signalflow graph
This is just a part of #328