Conversation
…p flag is on Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…loses On macOS, dismissing the native file picker opened from a web view (whether cancelling or selecting a file) activates Anki's main window instead of the non-modal dialog the picker was opened from, burying the dialog behind it. Inject a JS watcher on page load that reports when a file input's picker closes (cancel/change events), and raise + activate the dialog in response. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Proposed changes
AnkiHubWebViewDialogthat reports when a file input's picker closes (cancel/changeevents), and raise + activate the dialog in response. Lives in the shared base dialog, so it covers any AnkiHub web-view dialog that opens a file picker.How to reproduce
Further comments
Root-caused via instrumented repro runs: no code path (ours, Anki's, or the web app's) ever closed the dialog — every close/hide/Escape/pycmd path was ruled out, and a window-state probe showed the dialog
visible=True, exposed=False(occluded) while the main window became active. The regression test (test_dialog_is_raised_when_file_picker_closes) exercises the real seam (watcher JS →cancelevent → pycmd → dialog raised); note it runs in CI on Linux, as thepytest-forkedwebview harness segfaults on macOS. The underlying macOS focus behavior itself is only observable manually — worth a one-time QA check on macOS.Screenshots