fix: [#1052] bundled cleanup — 5 deferred items + 3 review-fixes #1085
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| // altimate_change start — #1052 D10 bot-review fix: shared build-input walk. | ||
| // | ||
| // The build stamp and the smoke-test staleness guard have to agree on exactly | ||
| // which files count as a build input. When the walk lived only inside build.ts, | ||
| // the guard could rehash the paths the stamp listed but had no way to notice a | ||
| // file ADDED after the build — a new module under any walked root left the | ||
| // binary stale while the guard stayed silent. Sharing the walk lets the guard | ||
| // re-enumerate with identical rules and compare sets, not just hashes. | ||
| import fs from "fs" | ||
| import path from "path" | ||
|
|
||
| /** Directories never part of a build input set. */ | ||
| export const IGNORED_DIRS = new Set(["node_modules", ".turbo", ".cache", "dist", "target"]) | ||
|
|
||
| /** | ||
| * Extensions Bun.build can pull into the binary from a walked source tree. | ||
| * `.mp3` is here because packages/tui imports its attention sounds with | ||
| * `{ type: "file" }`, so a changed or added sound is embedded in the binary and | ||
| * must invalidate the stamp like any source edit. | ||
| */ | ||
| export const INPUT_EXTENSIONS = /\.(tsx?|json|txt|md|mp3)$/ | ||
|
There was a problem hiding this comment. 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win Keep the mtime fallback input matcher aligned. Line 21 adds Use Proposed fix-import { walkInputs } from "../../script/stamp-inputs"
+import { INPUT_EXTENSIONS, walkInputs } from "../../script/stamp-inputs"
- if (!/\.(tsx?|json|txt|md)$/.test(entry.name)) continue
+ if (!INPUT_EXTENSIONS.test(entry.name)) continue🤖 Prompt for AI AgentsThere was a problem hiding this comment. P2: When a bundled workspace adds or edits a JavaScript or WASM asset under a walked Prompt for AI agentsThere was a problem hiding this comment. P2: When the stamp is missing or invalid, the mtime fallback ignores Prompt for AI agentsThere was a problem hiding this comment. [SUGGESTION]: Adding
Reply with |
||
|
|
||
| /** | ||
| * Absolute paths of every input file under `root`, applying the shared rules. | ||
| * Missing roots yield an empty list — callers treat that as "nothing to add". | ||
| */ | ||
| export function walkInputs(root: string): string[] { | ||
| const found: string[] = [] | ||
| const walk = (current: string): void => { | ||
| let entries: fs.Dirent[] | ||
| try { | ||
| entries = fs.readdirSync(current, { withFileTypes: true }) | ||
| } catch { | ||
| return | ||
| } | ||
| for (const entry of entries) { | ||
| if (entry.name.startsWith(".")) continue | ||
| if (IGNORED_DIRS.has(entry.name)) continue | ||
| const full = path.join(current, entry.name) | ||
| if (entry.isDirectory()) { | ||
| walk(full) | ||
| continue | ||
| } | ||
| if (!INPUT_EXTENSIONS.test(entry.name)) continue | ||
| found.push(full) | ||
| } | ||
| } | ||
| walk(root) | ||
| return found | ||
| } | ||
| // altimate_change end | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P1: The pre-push hook can approve one ref while pushing another because it never passes the hook's pushed ref/update data to the scanner; the scanner always examines the current
HEAD. A command such asgit push origin featurefrom a cleanmaincan therefore publish an unchecked branch. Reading the pre-push stdin tuples and scanning each pushed local OID (or restricting the hook to the checked-out ref) would align the check with the actual push.Prompt for AI agents