fix(lib): correctness bugs, dead import + lightweight tooling#175
Merged
Conversation
- errors.js: NotImplementedError now respects the message argument that every stub passes (was hardcoded and ignored) - optional-test-extension.js: return the test callback's promise so async test failures are awaited by node:test instead of leaking - simple-chain.js: remove broken `decorateObject` import (not exported by lib, never used) - package.json: drop bogus `main: index.js` (no such file) - add .nvmrc, .editorconfig and a CI workflow running `npm test` Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Cleanup of
lib/correctness bugs and a couple of housekeeping items. No task logic or test expectations changed —npm teststays green on the stubs (0 fail, 69 todo).Bug fixes
lib/errors.js—NotImplementedErrornow respects themessageargument that every stub already passes (new NotImplementedError('Not implemented')); previously the constructor hardcoded the string and silently ignored the arg.lib/optional-test-extension.js— the test callback now returns the promise from the async path, so async test failures are awaited bynode:testinstead of leaking as unhandled rejections.src/simple-chain.js— removed a brokendecorateObjectimport (not exported bylib, resolved toundefined, never used).Housekeeping
package.json— dropped the bogusmain: index.js(no such file)..nvmrc(22),.editorconfig, and a CI workflow runningnpm teston PRs/pushes.🤖 Generated with Claude Code