Skip to content

Low-hanging render performance improvements for logistics node & laptop - #90

Open
andrewsf wants to merge 1 commit into
Almana-mc:26.1.2from
andrewsf:Render-optimizations
Open

Low-hanging render performance improvements for logistics node & laptop#90
andrewsf wants to merge 1 commit into
Almana-mc:26.1.2from
andrewsf:Render-optimizations

Conversation

@andrewsf

@andrewsf andrewsf commented Jul 27, 2026

Copy link
Copy Markdown
  • Logistics node: remove fully occluded faces (44% reduction to 122)
  • Laptop: remove fully occluded faces (19% reduction to 208). Stripped pointless zero-rotation blocks (wasteful math)

Does not affect any visuals: logistics node textures will retain the weird stretched look.

Summary by CodeRabbit

  • Style
    • Refined the laptop model’s geometry and surface mapping for a cleaner, more consistent appearance.
    • Standardized logistics node model texture coordinates and formatting.
  • Bug Fixes
    • Improved face definitions and UV mappings across both models to help ensure textures render correctly.

* Logistics node: remove fully occluded faces (44% reduction to 122)
* Laptop: remove fully occluded faces (19% reduction to 208). Stripped pointless zero-rotation blocks (wasteful math)

Does not affect any visuals: logistics node textures will retain the weird stretched look.
@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b9bedca3-5ce2-45c9-8dc5-0beadcd784fb

📥 Commits

Reviewing files that changed from the base of the PR and between 3f894ba and a9085e3.

📒 Files selected for processing (2)
  • src/main/resources/assets/logisticsnetworks/models/block/laptop.json
  • src/main/resources/assets/logisticsnetworks/models/item/logistics_node.json

📝 Walkthrough

Walkthrough

Updated the laptop model’s cuboid rotations, directional faces, and UV mappings. Reformatted geometry and UV coordinate arrays in the logistics node item model while preserving its structure and texture references.

Changes

Laptop model geometry

Layer / File(s) Summary
Early laptop face mappings
src/main/resources/assets/logisticsnetworks/models/block/laptop.json
Early cuboid rotation metadata and face UV mappings are updated.
Laptop side-structure faces
src/main/resources/assets/logisticsnetworks/models/block/laptop.json
Repeated side cuboids remove rotations, reduce face definitions, and standardize upper-face UVs.
Laptop lower geometry
src/main/resources/assets/logisticsnetworks/models/block/laptop.json
Lower cuboids remove selected directional faces and rotations while updating retained UV mappings.

Logistics node model formatting

Layer / File(s) Summary
Geometry array formatting
src/main/resources/assets/logisticsnetworks/models/item/logistics_node.json
Numeric geometry and UV arrays are reformatted while model structure and texture references remain unchanged.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Suggested reviewers: almanax-21

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: render performance improvements for the logistics node and laptop.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@andrewsf

Copy link
Copy Markdown
Author

CodeRabbit's entire summary is wrong.

@AlmanaX-21

Copy link
Copy Markdown
Collaborator

Thanks for this, this PR will be merged after my rewrite is complete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants