Fix plugins check - #53
Open
tdivis wants to merge 2 commits into
Open
Conversation
* Fixed some unresolved imports and undefined variables * Removed lot of unused imports and variables, removed some re-imports * PEP8-ify white spaces, removed trailing spaces, blank lines are blank etc. * Added some false positive error/warning disabling for pylint and pydev * Did some refactoring to remove code duplication * Fixed lot of object's attributes were not defined in __init__ * Refactored some variable names to code be more readable * Removed some variables redefinitions (either build-ins and few locals)
Check for required_sane_plugins, called from is_skipped() in startTest was causing errors because not all plugins were enabled at that time (startTest methods of all plugins are called sequentially), so enable_test had to be moved to beforeTest plugin method. This was revealed by failing test testproject.test.test_database.TestFixturesLoadedProperly.test_model_loaded, which now passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check for required_sane_plugins, called from is_skipped() in startTest
was causing errors because not all plugins were enabled at that time
(startTest methods of all plugins are called sequentially), so enable_test
had to be moved to beforeTest plugin method.
This was revealed by failing test testproject.test.test_database.TestFixturesLoadedProperly.test_model_loaded, which now passes.