Lazy test database creation - #34
Open
andrejtokarcik wants to merge 10 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introducing laziness in the test database creation process: The test database is created if and only if a test with
no_database_interactionset toFalseis present in the set of the tests being run.Some minor code improvements included as well (commenting out the
leave_transaction_management()call might be disputable, though).BTW, I'm thinking about making DjangoDatabasePlugin in order to separate the stuff always needed (with fast pure unit tests as well as with database tests; such as handling mail outboxes, etc.) and the procedures relevant only for the database tests.