[DPG] tpcSkimsTableCreator: bugfix reserve tables size#16739
Open
lubynets wants to merge 4 commits into
Open
Conversation
|
O2 linter results: ❌ 1 errors, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tpcSkimsTableCreatorthere are two nested loops: collisions and tracks (V0s, cascades). Currently the reservation of the output table size is done inside the collision loop, while it should be done once per dataframe. It brings to underreservation of the size, which had no fatal effect before (although performance could worsen), but after these PRs, DPL Analysis: use unsafe cursor when reserving AliceO2#15450 and AOD Writer: correct reserve for cpvClusters AliceO2#15512 it brings to a fatal error. This PR fixes this logical error by bringing table reservation outside the collision loop;Tagging @amaringarcia