[PWGCF,PWGHF] Add Xic+ pi femto framework and Secondary Kaon from Omega#16736
Merged
Conversation
Extend FemtoDerived with FDHfCand3ProngXic for cascade-specific columns, register charm-cascade-hadrons-track-femto-dream workflows, and add XiC+ mass lookup in femtoDreamUtils. Co-authored-by: Cursor <cursoragent@cursor.com>
FDUEnrich
requested review from
NicoleBastid,
alibuild,
deepathoms,
fcatalan92,
fcolamar,
fgrosa,
hahassan7,
mfaggin,
mmazzilli and
vkucera
as code owners
FDUEnrich
requested review from
jaelpark,
jgrosseo and
wrzesaCERN
as code owners
|
O2 linter results: ❌ 170 errors, |
github-actions
Bot
changed the title
vkucera
reviewed
Jun 18, 2026
|
|
||
| if constexpr (Channel == DecayChannel::LcToPKPi) { | ||
| // Λc⁺ → p K π | ||
| // Lc+ -> p K pi |
Contributor
Author
There was a problem hiding this comment.
You are right, this comment-only change was not necessary. I changed it while normalizing comments to ASCII, but the original notation is clearer. I will restore the original physics notation here.
Collaborator
There was a problem hiding this comment.
This is just one of them. There are many.
Collaborator
There was a problem hiding this comment.
Please do not convert the comments to ASCII. Unicode is supported as long as the text is in English.
[PWGCF,PWGHF] Please consider the following formatting changes to AliceO2Group#16736
fgrosa
requested changes
Jun 19, 2026
fgrosa
left a comment
fgrosa
left a comment
Collaborator
There was a problem hiding this comment.
Hi @FDUEnrich the code looks good to me, thanks a lot! I just have a few cosmetic comments and then is ready to be merged (unless @zhangbiao-phy wants to have a another look).
| DECLARE_SOA_COLUMN(Prong0Id, prong0Id, int); //! Track id of charm hadron prong0 | ||
| DECLARE_SOA_COLUMN(Prong1Id, prong1Id, int); //! Track id of charm hadron prong1 | ||
| DECLARE_SOA_COLUMN(Prong2Id, prong2Id, int); //! Track id of charm hadron prong2 | ||
| DECLARE_SOA_COLUMN(XiProngId, xiProngId, int); //! Cascade id of the Xi prong in Xic -> Xi pi pi candidates |
Collaborator
There was a problem hiding this comment.
Maybe you can call it CascId in case we will ever use Omegas
Suggested change
| DECLARE_SOA_COLUMN(XiProngId, xiProngId, int); //! Cascade id of the Xi prong in Xic -> Xi pi pi candidates | |
| DECLARE_SOA_COLUMN(CascId, cascId, int); //! Cascade id of the Xi prong in Xic -> Xi pi pi candidates |
|
|
||
| /// Compute the charm hadron candidates mass with the daughter masses | ||
| /// assumes the candidate is either a D+ or Λc+ or D0 or Dstar | ||
| /// assumes the candidate is either a D+ or Lc+ or D0 or Dstar or Xic+ |
Collaborator
There was a problem hiding this comment.
Suggested change
| /// assumes the candidate is either a D+ or Lc+ or D0 or Dstar or Xic+ | |
| /// assumes the candidate is either a D+ or Λc+ or D0 or Dstar or Xic+ |
| invMass = cand.m(std::array{MassPiPlus, MassKPlus, MassProton}); | ||
| return invMass; | ||
| } else if constexpr (Channel == DecayChannel::DplusToPiKPi) { // D+ → π K π (PDG: 411) | ||
| } else if constexpr (Channel == DecayChannel::DplusToPiKPi) { // D+ -> pi K pi |
Collaborator
There was a problem hiding this comment.
Suggested change
| } else if constexpr (Channel == DecayChannel::DplusToPiKPi) { // D+ -> pi K pi | |
| } else if constexpr (Channel == DecayChannel::DplusToPiKPi) { // D+ -> π K π |
| invMass = cand.m(std::array{MassPiPlus, MassKPlus, MassPiPlus}); | ||
| return invMass; | ||
| } else if constexpr (Channel == DecayChannel::D0ToPiK) { // D0 → π K (PDG: 421) | ||
| } else if constexpr (Channel == DecayChannel::D0ToPiK) { // D0 -> pi K |
Collaborator
There was a problem hiding this comment.
Suggested change
| } else if constexpr (Channel == DecayChannel::D0ToPiK) { // D0 -> pi K | |
| } else if constexpr (Channel == DecayChannel::D0ToPiK) { // D0 -> π K |
| return invMass; | ||
| } | ||
| } else if constexpr (Channel == DecayChannel::DstarToD0Pi) { // D* → D0π (PDG: 413) | ||
| } else if constexpr (Channel == DecayChannel::DstarToD0Pi) { // D* -> D0 pi |
Collaborator
There was a problem hiding this comment.
Suggested change
| } else if constexpr (Channel == DecayChannel::DstarToD0Pi) { // D* -> D0 pi | |
| } else if constexpr (Channel == DecayChannel::DstarToD0Pi) { // D* -> D0 π |
| } | ||
|
|
||
| // D0 → K π + track (2-prong) | ||
| // D0 -> K pi + track (2-prong) |
Collaborator
There was a problem hiding this comment.
Suggested change
| // D0 -> K pi + track (2-prong) | |
| // D0 -> K π + track (2-prong) |
| } | ||
| } else if constexpr (Channel == DecayChannel::DplusToPiKPi) { | ||
| // D⁺ → π K π | ||
| // D+ -> pi K pi |
Collaborator
There was a problem hiding this comment.
Suggested change
| // D+ -> pi K pi | |
| // D+ -> π K π |
| massCharmTrk = {MassPiPlus, MassKPlus, MassPiPlus, trackMassHyp}; | ||
| } else if constexpr (Channel == DecayChannel::DstarToD0Pi) { | ||
| // D* → D0π | ||
| // D* -> D0 pi |
Collaborator
There was a problem hiding this comment.
Suggested change
| // D* -> D0 pi | |
| // D* -> D0 π |
Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch>
Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch>
Collaborator
|
Error while checking build/O2Physics/staging for 77eb72f at 2026-06-19 10:47: Full log here. |
Collaborator
|
Error while checking build/O2Physics/o2 for dbec298 at 2026-06-19 11:25: Full log here. |
Contributor
Author
|
This failure seems unrelated to the PR changes. The build failed because the remote execution/cache service used by recc became unavailable: |
zhangbiao-phy
left a comment
zhangbiao-phy
left a comment
Collaborator
There was a problem hiding this comment.
hi @FDUEnrich，Thanks a lot for the huge work! I already checked carefully and all good to me!
Collaborator
I converted it to draft because of the compilation error but you fixed it in the meantime. The jobs will rerun automatically since you marked the PR as ready for review. |
Collaborator
|
There is no need to trigger them. |
fgrosa
approved these changes
Jun 19, 2026
lauraser
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.