Skip to content

[PWGUD] Add new task upcVmRof.cxx#16497

Open
jgcn wants to merge 11 commits into
AliceO2Group:masterfrom
jgcn:sunriseJan26
Open

[PWGUD] Add new task upcVmRof.cxx#16497
jgcn wants to merge 11 commits into
AliceO2Group:masterfrom
jgcn:sunriseJan26

Conversation

@jgcn

@jgcn jgcn commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator

Task to study 2 and 4 track vector meson photonuclear production taking into account the ROF and the Time Frame of the candidate.

@alibuild alibuild mentioned this pull request Jun 2, 2026
Merged
@vkucera vkucera marked this pull request as draft June 2, 2026 09:39
@vkucera

vkucera commented Jun 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

@jgcn Your branch is five months old. Please update it and make sure that the PR passes the checks before you mark it as ready for review.

@github-actions

github-actions Bot commented Jun 2, 2026 •
edited
Loading

Copy link
Copy Markdown

O2 linter results: ❌ 14 errors, ⚠️ 7 warnings, 🔕 0 disabled

@jgcn jgcn marked this pull request as ready for review June 2, 2026 13:43
@jgcn jgcn enabled auto-merge (squash) June 2, 2026 13:44
@alibuild

alibuild commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 137a216 at 2026-06-02 15:46:

## sw/BUILD/O2Physics-latest/log
2026-06-02T15:45:39.107+0200 [49:139932491472512] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-06-02T15:45:39.107+0200 [49:139932491472512] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/upcVmRof.cxx:281:39: error: 'kNoTimeFrameBorder' is not a member of 'o2::aod::evsel'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/upcVmRof.cxx:284:39: error: 'kNoITSROFrameBorder' is not a member of 'o2::aod::evsel'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/upcVmRof.cxx:298:40: error: 'kNoTimeFrameBorder' is not a member of 'o2::aod::evsel'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/upcVmRof.cxx:301:40: error: 'kNoITSROFrameBorder' is not a member of 'o2::aod::evsel'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/upcVmRof.cxx:304:40: error: 'kIsVertexITSTPC' is not a member of 'o2::aod::evsel'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/upcVmRof.cxx:307:40: error: 'kNoSameBunchPileup' is not a member of 'o2::aod::evsel'
2026-06-02T15:45:39.008+0200 [48:140632603864704] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-06-02T15:45:39.008+0200 [48:140632603864704] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused
2026-06-02T15:46:06.649+0200 [48:140632603864704] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv6:%5B::1%5D:8980: Failed to connect to remote host: Connection refused]
ninja: build stopped: subcommand failed.

Full log here.

@jgcn jgcn disabled auto-merge June 2, 2026 13:48
@jgcn jgcn marked this pull request as draft June 2, 2026 13:48
@alibuild

alibuild commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 137a216 at 2026-06-02 15:49:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/upcVmRof.cxx:281:39: error: 'kNoTimeFrameBorder' is not a member of 'o2::aod::evsel'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/upcVmRof.cxx:284:39: error: 'kNoITSROFrameBorder' is not a member of 'o2::aod::evsel'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/upcVmRof.cxx:298:40: error: 'kNoTimeFrameBorder' is not a member of 'o2::aod::evsel'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/upcVmRof.cxx:301:40: error: 'kNoITSROFrameBorder' is not a member of 'o2::aod::evsel'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/upcVmRof.cxx:304:40: error: 'kIsVertexITSTPC' is not a member of 'o2::aod::evsel'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/upcVmRof.cxx:307:40: error: 'kNoSameBunchPileup' is not a member of 'o2::aod::evsel'
ninja: build stopped: subcommand failed.

Full log here.

vkucera
vkucera requested changes Jun 2, 2026
View reviewed changes
Comment thread PWGUD/Tasks/upcVmRof.cxx Outdated
Comment thread PWGUD/Tasks/upcVmRof.cxx
Comment on lines +162 to +168
// histograms
HistogramRegistry bcTH1Registry{"bcTH1Registry", {}};
std::map<std::string, std::shared_ptr<TH1>> bcTH1Pointers;
HistogramRegistry bcTH2Registry{"bcTH2Registry", {}};
std::map<std::string, std::shared_ptr<TH2>> bcTH2Pointers;
HistogramRegistry colTH1Registry{"colTH1Registry", {}};
std::map<std::string, std::shared_ptr<TH1>> colTH1Pointers;

@vkucera vkucera Jun 2, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you declare multiple registries?

Comment thread PWGUD/Tasks/upcVmRof.cxx Outdated
Comment on lines +178 to +179
static const int kRofPerOrbit = 6; // valid for pO, OO and PbPb in Run 3
static const int kRofShift = 64; // bc shift of ITS. Valid for pO, OO and PbPb in Run 3

@vkucera vkucera Jun 2, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use the k prefix.

@alibuild alibuild mentioned this pull request Jun 18, 2026
Merged
@alibuild alibuild mentioned this pull request Jun 19, 2026
Merged
@vkucera

vkucera commented Jun 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

@jgcn Why did you edit the header format and order again? They were already fixed by the first formatting PR that you merged before.

@jgcn
Merge pull request #3 from alibuild/alibot-cleanup-16497
e031c94 
Please consider the following formatting changes to AliceO2Group#16497
@jgcn jgcn marked this pull request as ready for review June 19, 2026 08:53
@jgcn jgcn enabled auto-merge (squash) June 19, 2026 08:54
@vkucera vkucera disabled auto-merge June 19, 2026 09:15
@vkucera

vkucera commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

Sorry @jgcn but the PR is not OK for merging. It does not pass the checks and it's touching an unrelated file in PWGMM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkucera vkucera vkucera requested changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@amatyja amatyja Awaiting requested review from amatyja amatyja is a code owner

@rolavick rolavick Awaiting requested review from rolavick rolavick is a code owner

@omvazque omvazque Awaiting requested review from omvazque omvazque is a code owner

@mpuccio mpuccio Awaiting requested review from mpuccio mpuccio is a code owner

@skundu692 skundu692 Awaiting requested review from skundu692 skundu692 is a code owner

@aalkin aalkin Awaiting requested review from aalkin aalkin is a code owner

@gbencedi gbencedi Awaiting requested review from gbencedi gbencedi is a code owner

@abmodak abmodak Awaiting requested review from abmodak abmodak is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

pwglf pwgmm pwgud

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jgcn @vkucera @alibuild