Fix black mission briefing map textures - #3
Draft
isaac-ranger wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gos_Texture_Solidtextures populated throughLock()/Unlock()mc2_02runtime verificationRoot cause
The briefing thumbnail is passed to
textureFromMemory()asgos_Texture_Solid. That path creates an empty texture, locks it, copies the source BGRA pixels, and unlocks it. Unlike the file-backed and encoded-memory paths, it bypassesconvertIfNecessary()/makeKindaSolid(), so legacy zero-alpha values from the otherwise healthy source TGA reached the OpenGL texture. Normal alpha blending then exposed the black destination behind the map quad.gosTexture::Unlock()now forces alpha to 255 only forgos_Texture_Solidwhile performing its existing BGRA-to-RGBA conversion. Keyed and alpha formats keep their source alpha.Validation
gameostarget compiles and links successfully in the native Linux buildmc2_02mission-briefing verification showed blue water, colored terrain/buildings, the normal red objective marker, and a textured objective model with no black map regions or black texture quadsScope
This PR changes only
GameOS/gameos/gameos_graphics.cppand the existing briefing-map investigation devlog. It adds no assets, binaries, launchers, campaign overrides, or other test-harness files.