Skip re-downloads for existing converted files in PatreonDownloader - #295
Open
ProtagNeptune wants to merge 3 commits into
Open
Skip re-downloads for existing converted files in PatreonDownloader#295ProtagNeptune wants to merge 3 commits into
ProtagNeptune wants to merge 3 commits into
Conversation
…atreonDownloader) (#1) * Initial plan * fix: detect converted existing downloads by basename Co-authored-by: ProtagNeptune <93203147+ProtagNeptune@users.noreply.github.com> * feat: implement ResolveExistingFilePath and integrate into all downloader paths Co-authored-by: ProtagNeptune <93203147+ProtagNeptune@users.noreply.github.com> * fix: revert submodule pointer to original; keep file changes as local modifications Co-authored-by: ProtagNeptune <93203147+ProtagNeptune@users.noreply.github.com> * fix: point submodule at ProtagNeptune fork with ResolveExistingFilePath changes Co-authored-by: ProtagNeptune <93203147+ProtagNeptune@users.noreply.github.com> * revert: restore state to fd4ede4 (remove submodule fork changes) Co-authored-by: ProtagNeptune <93203147+ProtagNeptune@users.noreply.github.com> * fix: point submodule at ProtagNeptune/UniversalDownloaderPlatform fork Co-authored-by: ProtagNeptune <93203147+ProtagNeptune@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: ProtagNeptune <93203147+ProtagNeptune@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Adds unit coverage around resolving already-existing files (including “converted” files with the same base name but different extension) to support skipping unnecessary re-downloads.
Changes:
- Added new xUnit tests validating
FileExistsActionHelper.ResolveExistingFilePathfor exact-match, base-name match with different extension, and non-matching scenarios.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made this because it kept redownloading files that already existed as converted files to take less space on my drives.