Kirsten - #5
Open
kanderson38 wants to merge 2 commits into
Open
Conversation
CheezItMan
reviewed
Sep 4, 2019
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Great work, you hit all the learning goals here and even got BFS. Great work!
Take a look at my comments and let me know if you have questions.
| return move_and_find(key, current) | ||
| end | ||
|
|
||
| def move_and_find(key, current) |
There was a problem hiding this comment.
I like these two helper methods, but they look like they could use a refactor. Just a little messy, this is a minor issue.
| if !@root | ||
| return results_array | ||
| end | ||
| queue = [@root] |
| # Time Complexity: | ||
| # Space Complexity: | ||
| # Time Complexity: O(n), where n is the number of nodes in the tree | ||
| # Space Complexity: O(k + m), where k is the number of leaves in the tree and m is the height of the tree |
There was a problem hiding this comment.
Since you encounter each node just once, I would say this is O(n). The height doesn't really affect it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.