fix: Don't panic on recoverable D-Bus errors on Unix#741
Open
DataTriny wants to merge 1 commit into
Open
Conversation
DataTriny
force-pushed
the
atspi-bus-panics
branch
from
f874951 to
ac7ffd8
Compare
Member
Author
|
@ogoffart Could you please confirm that this doesn't crash a Slint application anymore on your broken AT-SPI setup? I haven't thought too much about the tracing/logging story for AccessKit yet and this needs to be the same for all adapters, so that will come later. Thanks. |
|
Thanks! Yes, this solves the panic i had. |
mwcampbell
approved these changes
Jul 12, 2026
mwcampbell
left a comment
mwcampbell
left a comment
Contributor
There was a problem hiding this comment.
LGTM. @DataTriny Please merge when ready.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #727
A system misconfiguration, a broken AT-SPI registry implementation or an adversarial assistive technology should never make the host application crash. This pull request ensure only a bug on our side can lead to a panic.