Add regression tests for predictor sweeps, async snapshot, and harvest siblings - #20
Draft
cursor[bot] wants to merge 3 commits into
Draft
Add regression tests for predictor sweeps, async snapshot, and harvest siblings#20cursor[bot] wants to merge 3 commits into
cursor[bot] wants to merge 3 commits into
Conversation
Cover that movers without SingleTrajectory stay static boxes, predicted agents sweep forward, and beside/behind gates honor beside_rear_window. Co-authored-by: Majid Khonji <majid-khonji@users.noreply.github.com>
Prove combined planner/perception worker fetches once per iteration and skips get_sensor_frame when no stage module is active. Co-authored-by: Majid Khonji <majid-khonji@users.noreply.github.com>
Add GlobalPlan/localization harvest notify-once tests, DETECTION GT list-copy isolation from world NPCs, and update_waypoint_by_xy_forward anti-backjump behavior. Co-authored-by: Majid Khonji <majid-khonji@users.noreply.github.com>
This was referenced Aug 1, 2026
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds focused regression coverage for high-risk paths that recent execution/planning work left thinly tested. Complements (does not duplicate) open draft PRs #17/#18.
Risky behavior now covered
precompute_obstacle_polygons): movers withoutSingleTrajectorystay static boxes; predicted agents sweep forward; far-behind agents are not beside-swept; just-behind agents usebeside_sweep_timeget_sensor_frameper iteration shared by replan+perceive; no fetch when no stage module is activestack_eventharvest siblings:GlobalPlan.stack_eventand localizationpm.stack_eventnotify once then clearupdate_waypoint_by_xy_forward: never movescurrent_wpbackward; honorsmin_wpfloorTest files added/updated
test/c50_common/test_c55_collision_checking.pytest/c40_execution/test_c42_sensor_snapshot.pytest/c40_execution/test_c43_task_strategy.pytest/c50_common/test_c54_trajectory_waypoint_update.pyWhy these tests materially reduce regression risk
These paths sit on lattice collision costs, CARLA-async sensor timing, task automation signals, GT detection isolation, and HDMap waypoint tracking. Silent regressions here produce unsafe lattice costs, stage desync on shared sensors, missed task events, despawned world NPCs, or path-index backjumps after sharp turns.
Validation
All 35 tests passed. No production code changes.