Network: Perform a range check before using array offset - #163
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR hardens several Network component loops by ensuring bounds checks are evaluated before array indexing, preventing potential out-of-range reads when inputs are not properly terminated or are truncated.
Changes:
- Reordered short-circuit conditions to check index/limit before dereferencing
buf[idx],passw[i], andsp[i]. - Updated copyright headers to 2026 in the touched Network source files.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Components/Network/Source/net_smtp_client_core.c | Ensures the i < 64 bound is checked before reading passw[i] in HMAC-MD5 key preparation. |
| Components/Network/Source/net_dns_client.c | Ensures idx < len is checked before reading buf[idx] when skipping an uncompressed DNS name. |
| Components/Network/Source/net_common.c | Ensures i < nb is checked before reading sp[i] in net_strnchr. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
RobertRostohar
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.