Skip to content

Responsive layout#70

Open
edoardocavazza wants to merge 9 commits into
masterfrom
responsive
Open

Responsive layout#70
edoardocavazza wants to merge 9 commits into
masterfrom
responsive

Conversation

@edoardocavazza

@edoardocavazza edoardocavazza commented Jun 14, 2020

Copy link
Copy Markdown
Member

Issue: #62

  • Fixed some alignment issues
  • Responsive layout
  • Sticky header

Extra:

@nicolocarpignoli

Copy link
Copy Markdown
Member

@edoardocavazza it's great to me! Only one thing: it's possible to add a bigger padding on the left on each page? Something that will make the whole content not so sticky to the left margin.

For the rest, it scales great.

@nicolocarpignoli

Copy link
Copy Markdown
Member

I have aligned the branch to latest modifies.

@mingiryu mingiryu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edoardocavazza Definitely looks better for responsive. I don't think the back anchor component will work when it gets merged to master. If we keep what you implemented and hardcore /studio/ in front to fix for prod, then it won't work for local dev, and vice versa. I wish I knew a better way to handle it.

Comment thread index.html
Comment thread pages/location/index.html

<div class="pages-content">
<back-anchor assetsUrl="../../assets"></back-anchor>
<back-anchor href="/" assetsUrl="../../assets"></back-anchor>

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The works for local dev, but unfortunately, it doesn't work for the prod. The reason is because the root URL on prod is https://github.com/AR-js-org/studio

Comment thread style.css Outdated
@gciandro13 gciandro13 self-assigned this Sep 17, 2020
@gciandro13
gciandro13 self-requested a review October 29, 2020 08:07
@gciandro13

Copy link
Copy Markdown
Member

@thauska hi :) still actual ?

@thauska

thauska commented Oct 7, 2023

Copy link
Copy Markdown
Member

I can see it today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Marker Page: back button

5 participants