Skip to content

fix: prevent mutation of repos array while sorting top repositories #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GaneshDeshmane wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: prevent mutation of repos array while sorting top repositories #729

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions jsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"compilerOptions": {
"baseUrl": ".",
"ignoreDeprecations": "6.0",
"paths": {
"@/*": ["src/*"]
}
Expand Down
6 changes: 5 additions & 1 deletion src/app/api/stats/route.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,11 @@ export async function GET() {
// Fetching contributors for ALL repos consumes too much rate limit (N requests).
// We will proactively fetch contributors for the top 6 most starred/popular repos to get a good estimate.
// Sorting repos by stargazers_count
const topRepos = repos.sort((a, b) => b.stargazers_count - a.stargazers_count).slice(0, 6);

const topRepos = [...repos]
.sort((a, b) => b.stargazers_count - a.stargazers_count)
.slice(0, 6);


const contributorIds = new Set();

Expand Down