Skip to content

chore: drop gitmoji commit enforcement - #534

Merged
Nicola Franco (franconicola) merged 1 commit into
mainfrom
chore/drop-gitmoji-commit-check
Jul 26, 2026
Merged

chore: drop gitmoji commit enforcement#534
Nicola Franco (franconicola) merged 1 commit into
mainfrom
chore/drop-gitmoji-commit-check

Conversation

@franconicola

Copy link
Copy Markdown
Member

Summary

  • Remove the commit-check CI job (cz check) and the local commitizen pre-commit hook, both of which required gitmoji-style commit messages via cz-conventional-gitmoji.
  • Switch [tool.commitizen] from cz_gitmoji to cz_conventional_commits (commitizen itself stays, for version bumping/changelog generation).
  • Update CONTRIBUTING.md to stop referencing the removed commit-msg hook and CI enforcement.
  • All other CI jobs (linting, unit/integration/e2e tests) are unchanged.

Test plan

  • uv lock resolves cleanly after dropping cz-conventional-gitmoji
  • .github/workflows/ci.yml and .pre-commit-config.yaml parse as valid YAML
  • CI run on this PR (commit-message job no longer present)

Remove the CI commit-check job and the local commitizen pre-commit
hook, both of which required gitmoji-style commit messages via
cz-conventional-gitmoji. Switch commitizen to plain conventional
commits (still used for version bumping/changelog generation) and
update CONTRIBUTING.md accordingly.
Copilot AI review requested due to automatic review settings July 26, 2026 20:23

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes repository-wide gitmoji-based commit message enforcement while keeping Commitizen for versioning/changelog workflows, aligning the project with plain Conventional Commits without CI/local hook gating.

Changes:

  • Removed the CI “Commit Messages” job that ran cz check on PR commit ranges.
  • Removed the Commitizen commit-msg pre-commit hook and dropped cz-conventional-gitmoji from dependencies/lockfile.
  • Switched Commitizen configuration from cz_gitmoji to cz_conventional_commits and updated contributing docs accordingly.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
uv.lock Removes cz-conventional-gitmoji from the resolved dependency set (plus incidental lock marker updates from regeneration).
pyproject.toml Drops the gitmoji adapter dependency and updates Commitizen to cz_conventional_commits.
CONTRIBUTING.md Updates local setup instructions and removes references to commit-msg/CI enforcement for commit messages.
.pre-commit-config.yaml Removes the Commitizen commit-msg hook configuration.
.github/workflows/ci.yml Removes the commit-check job that enforced commit message format in CI.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov

codecov Bot commented Jul 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@franconicola
Nicola Franco (franconicola) merged commit ea2f826 into main Jul 26, 2026
23 checks passed
@franconicola
Nicola Franco (franconicola) deleted the chore/drop-gitmoji-commit-check branch July 26, 2026 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants