[WIP] Add Flask as additional dependency for web dashboard - #520
Conversation
|
@claude[agent] fix the CI Checks / Commit Messages |
I can't fix this automatically: the failing commits are Could you force-push a rebase with reworded messages (e.g. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
@claude[agent] fix the CI Checks / Commit Messages |
I reworded both commits locally to To get the job green, either force-push the reworded history yourself, or squash-merge this PR with a conventional message. Alternatively, if you'd prefer, I can close this and open a fresh PR with a single correctly-formatted commit. |
|
@claude[agent] fix the tests |
The two test failures aren't caused by this PR — the only change here is moving Failing job: Integration Tests (Ollama, fast),
That's If you'd rather make it not flaky, I can add a fixture that skips these integration tests when the backend returns 429 — say the word and I'll do it, but I didn't want to silently mask backend errors in a dependency-only PR. |
Agent-Logs-Url: https://github.com/AISecurityLab/hackagent/sessions/fc9f76d1-c07f-494d-9e1b-9196a8fc5ee1 Co-authored-by: franconicola <51865029+franconicola@users.noreply.github.com>
998f09d to
76f2600
Compare
There was a problem hiding this comment.
Pull request overview
Adds Flask to the project’s default install set so hackagent web can run without requiring users to manually install Flask, addressing the missing-dependency report in #410.
Changes:
- Add
flask>=3.1.2to[project].dependencies. - Remove Flask from the
devdependency group. - Update
uv.lockto reflect Flask as a runtime dependency (and remove it from dev deps).
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| uv.lock | Locks Flask as a runtime dependency and removes it from dev-only requirements. |
| pyproject.toml | Promotes Flask to a core dependency and removes it from the dev group. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "playwright>=1.40", | ||
| "Pillow>=10.0.0", | ||
| "flask>=3.1.2", | ||
| ] |
Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.