Skip to content

[WIP] Add Flask as additional dependency for web dashboard - #520

Merged
Nicola Franco (franconicola) merged 1 commit into
mainfrom
claude/add-flask-in-dependencies
Jul 26, 2026
Merged

[WIP] Add Flask as additional dependency for web dashboard#520
Nicola Franco (franconicola) merged 1 commit into
mainfrom
claude/add-flask-in-dependencies

Conversation

@Claude

@Claude Claude AI commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.


This section details on the original issue you should resolve

<issue_title>Add Flask in dependencies</issue_title>
<issue_description>Describe the bug
Missing Flask from the standard dependencies.

To Reproduce
uv run hackagent web
❌ Flask is required for the web dashboard.

Install with:
pip install 'hackagent'

or

pip install flask

Expected behavior
adding flask as additional dependencies for dashboard (web)
</issue_description>

Comments on the Issue (you are @claude[agent] in this section)

@franconicola

Copy link
Copy Markdown
Member

@claude[agent] fix the CI Checks / Commit Messages

@Claude

Claude AI commented Jul 26, 2026

Copy link
Copy Markdown
Contributor Author

@claude[agent] fix the CI Checks / Commit Messages

I can't fix this automatically: the failing commits are e9a99fe ("Initial plan") and ff0ba5e ("Add flask to main dependencies for web dashboard"), neither of which matches the cz check conventional/gitmoji format this repo requires. Fixing it needs a reword + force-push, but I don't have force-push access in this environment (only fast-forward/rebase pushes, which drop content-identical reworded commits as duplicates).

Could you force-push a rebase with reworded messages (e.g. fix(deps): add flask as a main dependency for web dashboard), or let me know if a squash-merge is acceptable instead?

@codecov

codecov Bot commented Jul 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@franconicola

Copy link
Copy Markdown
Member

@claude[agent] fix the CI Checks / Commit Messages

@Claude

Claude AI commented Jul 26, 2026

Copy link
Copy Markdown
Contributor Author

@claude[agent] fix the CI Checks / Commit Messages

I reworded both commits locally to 🧹 chore: initial plan for adding flask dependency and ✨ feat(deps): add flask as a main dependency for the web dashboard, and verified cz check --rev-range passes on that history. But publishing it requires a force-push, which I don't have: my push was rebased onto the remote branch, so the original e9a99fe / ff0ba5e are still there and cz check still fails on them (only 998f09d landed).

To get the job green, either force-push the reworded history yourself, or squash-merge this PR with a conventional message. Alternatively, if you'd prefer, I can close this and open a fresh PR with a single correctly-formatted commit.

@franconicola

Copy link
Copy Markdown
Member

@claude[agent] fix the tests

@Claude

Claude AI commented Jul 26, 2026

Copy link
Copy Markdown
Contributor Author

@claude[agent] fix the tests

The two test failures aren't caused by this PR — the only change here is moving flask from the dev group to the main dependencies in pyproject.toml/uv.lock.

Failing job: Integration Tests (Ollama, fast), tests/integration/router/test_litellm_dispatch.py:

  • test_router_dispatch_returns_standardised_envelopeRemoteBackend: Failed to create agent 'openai/gpt-4o-mini' (status 429, "Request was throttled. Expected available in 711 seconds.")
  • test_router_dispatch_supports_prompt_field — same 429 on agent list, then /organization/me returned 401.

That's api.hackagent.dev rate-limiting the shared CI key (retry-after: 711), not a code failure. The identical commit content passed this job in the earlier run on ff0ba5e (only Commit Messages failed there), so re-running the job now that the throttle window has expired should be green.

If you'd rather make it not flaky, I can add a fixture that skips these integration tests when the backend returns 429 — say the word and I'll do it, but I didn't want to silently mask backend errors in a dependency-only PR.

@franconicola
Nicola Franco (franconicola) force-pushed the claude/add-flask-in-dependencies branch from 998f09d to 76f2600 Compare July 26, 2026 15:36
@franconicola
Nicola Franco (franconicola) marked this pull request as ready for review July 26, 2026 15:55
Copilot AI review requested due to automatic review settings July 26, 2026 15:55

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@franconicola
Nicola Franco (franconicola) merged commit a5fd979 into main Jul 26, 2026
24 checks passed
@franconicola
Nicola Franco (franconicola) deleted the claude/add-flask-in-dependencies branch July 26, 2026 15:56

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Flask to the project’s default install set so hackagent web can run without requiring users to manually install Flask, addressing the missing-dependency report in #410.

Changes:

  • Add flask>=3.1.2 to [project].dependencies.
  • Remove Flask from the dev dependency group.
  • Update uv.lock to reflect Flask as a runtime dependency (and remove it from dev deps).

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
uv.lock Locks Flask as a runtime dependency and removes it from dev-only requirements.
pyproject.toml Promotes Flask to a core dependency and removes it from the dev group.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pyproject.toml
Comment on lines 36 to 39
"playwright>=1.40",
"Pillow>=10.0.0",
"flask>=3.1.2",
]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Flask in dependencies

3 participants