chore(release): 3.6.2 — commit SDK lockfiles (fixes failed SDK publish)#71
Merged
Conversation
Real root cause of the 3.6.0/3.6.1 SDK build failures: sdk/{node,python}/Cargo.lock
were git-ignored, so CI re-resolved the SDK dep graph fresh each release and
pulled a newly-published alloc-no-stdlib 3.0.0 next to 2.0.4 — a duplicate that
breaks brotli 8.0.3's StandardAlloc: Allocator impl. (The 3.6.1 toolchain pin
was a misdiagnosis.)
- Track sdk/node/Cargo.lock + sdk/python/Cargo.lock (remove from .gitignore,
add !Cargo.lock negation) so CI builds the exact pinned resolution: single
alloc-no-stdlib 2.0.4 + brotli 8.0.3.
- Bump version surface 3.6.1 -> 3.6.2.
- Verified with real cargo build --release for BOTH SDKs locally (exit 0), not
just cargo check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Real fix for the 3.6.0/3.6.1 SDK publish failures.
Root cause (now confirmed)
sdk/node/Cargo.lockandsdk/python/Cargo.lockwere git-ignored — never committed. So CI resolved the SDK dependency graph fresh on every release. A newly-publishedalloc-no-stdlib 3.0.0got pulled alongside2.0.4, producing a duplicate that breaksbrotli 8.0.3'sStandardAlloc: alloc::Allocatorimpl → all native SDK builds failed → npm/PyPI/GH skipped (twice). The 3.6.1 toolchain pin was a misdiagnosis (it fails the same way on any toolchain when the lock isn't honored).Fix
.gitignore+!Cargo.locknegation). CI now builds the exact, pinned resolution — singlealloc-no-stdlib 2.0.4+brotli 8.0.3— instead of re-resolving.Verification (the step I should have done before)
Ran the real CI command
cargo build --release --target aarch64-apple-darwinlocally for both SDKs (Node + Python) on the committed lock → exit 0, brotli compiles. Pluscargo fmt --check,clippy -D warnings,check-version.sh 3.6.2✅.Merging then tagging
v3.6.2should finally ship npm/PyPI/GH. crates.io will add core 3.6.2 (3.6.0/3.6.1 already there).