chore(release): 3.6.1 — fix SDK release build (pin toolchain + refresh locks)#70
Merged
Conversation
3.6.0 published a3s-code-core to crates.io but the native SDK builds failed:
brotli 8.0.3 (transitive via tower-http under ahp/s3) no longer compiles on the
newest stable Rust, so npm/PyPI/GH Release were skipped. This ships them.
- Pin publish-{node,python}.yml to dtolnay/rust-toolchain@1.94.1 + maturin-action
rust-toolchain: 1.94.1 (known-good; matches earlier releases)
- Refresh sdk/{node,python}/Cargo.lock to a3s-code-core 3.6.1 (were stale at
3.5.0, forcing a dep re-resolution that pulled a duplicate alloc-no-stdlib)
- Bump version surface 3.6.0 -> 3.6.1
- Verified locally: cargo check on both SDK manifests compiles on rustc 1.94.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release-engineering fix for 3.6.0. No library code changes.
What happened with 3.6.0
Tagging
v3.6.0publisheda3s-code-coreto crates.io ✅, but all native SDK build jobs failed → npm / PyPI / GitHub Release were skipped (still at 3.5.0).Root cause: brotli 8.0.3 (transitive via
tower-http → async-compression, required by theahp/s3features) no longer compiles on the newest stable Rust —error[E0277]: StandardAlloc: alloc::Allocator. It built fine for 3.5.0 a week ago; a new stable landed since. Not related to the 3.6.0 feature code. (crates.io's core publish uses default features, which don't pull brotli, so it succeeded.)Fix
publish-node.yml/publish-python.ymlnow usedtolnay/rust-toolchain@1.94.1(andmaturin-actionrust-toolchain: 1.94.1) instead of@stable— the known-good toolchain that shipped earlier releases.sdk/{node,python}/Cargo.locktoa3s-code-core 3.6.1(they were stale at 3.5.0, which forced a dep re-resolution that pulled a duplicatealloc-no-stdlib 3.0.0). Locks now resolve cleanly: brotli 8.0.3, single alloc-no-stdlib.Verification
cargo checkon both SDK manifests compiles on rustc 1.94.1 (the pinned CI version, with ahp+s3 → brotli) — this is the build CI will now run.cargo fmt --all -- --check✅ ·cargo clippy --workspace --lib --bins -- -D warnings✅ ·check-version.sh 3.6.1✅Merging this then tagging
v3.6.1re-runs the release; the SDK builds should now pass and ship npm/PyPI/GH. crates.io will gaina3s-code-core 3.6.1(3.6.0 stays as a core-only release).