Force-close channels that our peer claims are late without proving it - #3360
Merged
Conversation
t-bast
reviewed
Aug 21, 2026
t-bast
left a comment
t-bast
left a comment
Member
There was a problem hiding this comment.
Just a couple of nits, feel free to ignore
t-bast
previously approved these changes
Aug 21, 2026
…#100) When our peer claims, in their channel_reestablish message, that we're late but don't prove it, we force-close the channel instead of transitioning to WAIT_FOR_REMOTE_PUBLISH_FUTURE_COMMITMENT. There is a special case where we are late but safe because they don't have our revocation secret: we use the commitment point from their `channel_resstablish` message to spend their commit tx if they publish it, as we would in WAIT_FOR_REMOTE_PUBLISH_FUTURE_COMMITMENT.
pm47
force-pushed
the
force-close-outdated
branch
from
August 21, 2026 12:35
0f3b10b to
d1a6e49
Compare
Member
Author
|
Rebased to fix build failure. |
t-bast
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When our peer claims, in their channel_reestablish message, that we're late but don't prove it, we force-close the channel instead of transitioning to
WAIT_FOR_REMOTE_PUBLISH_FUTURE_COMMITMENT.There is a special case where we are late but safe because they don't have our revocation secret: we use the commitment point from their
channel_reestablishmessage to spend their commit tx if they publish it, as we would inWAIT_FOR_REMOTE_PUBLISH_FUTURE_COMMITMENT.Supersedes #3358. Credits @sstone.