fix(sherpaonnx): accept numeric values in credentials JSON - #13
Merged
Conversation
The strict HashMap<String, String> parse silently discarded the entire
credentials object when any value was a JSON number (e.g.
{"numThreads": 2}), leaving every option at its default with no
error — VoiceGarden-SPD hit this shipping numThreads as a number.
Coerce numbers to their string form instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A strict
HashMap<String, String>parse silently discards the entire credentials object when any value is a JSON number.{"modelId": "kokoro-en-v0_19", "numThreads": 2}therefore came up with no model at all — no error, just a later 'no modelId configured' failure that looks unrelated. VoiceGarden-SPD shippednumThreadsas a number and hit exactly this.What
Parse as
HashMap<String, Value>and coerce numbers to their string form (booleans/null keep their JSON text — callers don't use them today). String values pass through unchanged.Testing
New unit test constructs an engine with numeric
numThreads/numStepsand asserts both take effect.