fix(google): pin MP3 output to 24 kHz - #12
Merged
Conversation
Without sampleRateHertz Google returns audio at each voice's natural rate (22050/24000/32000 depending on model family), so downstream consumers that receive bare PCM via on_audio cannot know the rate. Pinning 24000 makes the delivery rate deterministic for every voice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Without
sampleRateHertzGoogle returns audio at each voice's natural rate (22050/24000/32000 depending on model family), so downstream consumers that receive bare PCM viaon_audiocannot know the rate — VoiceGarden-SPD had to guess and would play some voices at the wrong speed.What
One-line pin:
audioConfig.sampleRateHertz = 24000alongside the existingMP3encoding, making the decoded PCM rate deterministic for every voice. (Verified against the live API: voices listnaturalSampleRateHertzof 22050/24000/32000, so the pin genuinely changes output for some voices.)Cherry-picked from the
feat/vgspd-integrationintegration branch where it was originally committed.