Merge into 21R4 branch#118
Merged
Merged
Conversation
[Bug]: no error thrown when the server is started in TLS v1.3
#22761
Microsoft Graph webhook subscriptions require the notification endpoint
to accept TLS 1.2 connections. If the host web server is already running
with minTLSVersion set above TLSv1.2 (e.g. TLSv1.3 only), Graph
subscription callbacks silently fail during validation with no
actionable error message.
Changes:
- _NotificationHelper.ensureWebServer: when reusing the host HTTPS
server, check that minTLSVersion <= TLSv1_2; return
{success: False; tlsVersionInsufficient: True} otherwise
- GraphNotification._startPush, GoogleNotification._startCalendarPush,
GoogleNotification._startMailPush: distinguish tlsVersionInsufficient
from a port-conflict and raise error 18 instead of error 7
- Add ERR_4DNK_18 to all six localization files (EN, FR, DE, ES, JA, PT)
…ons for improved readability and performance
…cond argument. GoogleNotification already supported labelIds, but the value was never propagated from GoogleMail.notifier. - add support for Google.mail.notifier(param; labelId) - map labelId to param.labelIds (initialize when needed) - prevent duplicates in labelIds - keep Google.calendar.notifier(param; calendarId) behavior unchanged - update notification docs (signatures and examples) Fixes #22966
… pull mode (#22967) Fixes a bug where the expiration attribute could be returned in timer (pull) mode. - Keep expirationMs as a numeric source of truth - Convert to GMT ISO datetime string only in the expiration getter - Add validation to prevent silent fallback to pull when Gmail is configured with endPoint but without topicName - Explicitly reset expiration when starting in pull mode - Add defensive guardrails: never assign expiration in pull mode, and always return empty expiration in pull mode Issue: #22967 Fixes: #22967
- Changed parameter syntax for notifier methods in Google and Graph sections to use curly braces for object parameters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.