Skip to content

chore: drop python 3.10 tests on napari repository#1427

Merged
Czaki merged 1 commit into
developfrom
update_napari_repo_tests
Jul 13, 2026
Merged

chore: drop python 3.10 tests on napari repository#1427
Czaki merged 1 commit into
developfrom
update_napari_repo_tests

Conversation

@Czaki

@Czaki Czaki commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

Napari dropped python 3.10 so we cannot test against it in napari_repo tests

Summary by Sourcery

Update napari repository testing to align with supported Python versions by dropping 3.10 and adding 3.14.

CI:

  • Adjust GitHub Actions napari_repo workflow matrix to stop testing against Python 3.10 and start testing against Python 3.14.

Tests:

  • Update tox napari_repo test environments to remove Python 3.10 and include Python 3.14.

Summary by CodeRabbit

  • Tests
    • Updated automated test coverage to target Python 3.11–3.14.
    • Removed Python 3.10 from the supported test environment matrix.
    • Added Python 3.14 coverage across supported Qt configurations.

@sourcery-ai

sourcery-ai Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Update CI and tox configuration to stop testing napari_repo against Python 3.10 and align supported versions with napari’s current matrix.

Flow diagram for updated napari_repo Python test matrix

flowchart LR
    gha[GitHub_Actions test_napari_repo workflow]
    tox[tox napari_repo envs]

    gha --> tox

    subgraph Python_versions
        py311[py311]
        py312[py312]
        py313[py313]
        py314[py314]
        py315[py315]
    end

    tox --> py311
    tox --> py312
    tox --> py313
    tox --> py314
    tox --> py315
Loading

File-Level Changes

Change Details Files
Adjust GitHub Actions workflow matrix to drop Python 3.10 and add Python 3.14 for napari_repo tests.
  • Update the python matrix in the test_napari_repo workflow to remove Python 3.10.
  • Extend the python matrix in the workflow to include Python 3.14 alongside existing versions.
.github/workflows/test_napari_repo.yml
Update tox environment definitions to stop generating napari_repo testenvs for Python 3.10.
  • Modify the pyX-napari_repo tox env factor list to start at Python 3.11 instead of 3.10.
  • Keep existing GUI backend factors (PyQt5, PyQt6, PySide6) unchanged while updating the Python version set.
tox.ini

Possibly linked issues

  • #test-bot napari repos test fail: Issue reports napari_repo CI failing on py3.10; PR fixes by dropping py3.10 from workflow and tox envs.
  • #test-bot napari repos test fail: PR removes Python 3.10 from napari_repo workflows and tox, directly addressing the reported failing tests.
  • #test-bot napari repos test fail: PR removes Python 3.10 from napari_repo tests, directly addressing the tracked 3.10 workflow failure.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The napari repository test matrix no longer runs Python 3.10. GitHub Actions adds Python 3.14, and the corresponding tox environment targets Python 3.11 through 3.15 across the existing Qt backends.

Changes

Napari test matrix

Layer / File(s) Summary
Update napari test versions
.github/workflows/test_napari_repo.yml, tox.ini
The CI matrix removes Python 3.10 and adds Python 3.14; the tox napari_repo environment now covers Python 3.11–3.15 with the existing Qt backends.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Suggested reviewers: dependabot[bot], pre-commit-ci[bot]

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: removing Python 3.10 tests from the napari repository.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch update_napari_repo_tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Confirm that Python 3.14/3.15 are actually available and supported in both GitHub Actions and your tooling, as adding them to the matrix/tox env while they’re not installable will cause CI failures unrelated to napari’s 3.10 deprecation.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Confirm that Python 3.14/3.15 are actually available and supported in both GitHub Actions and your tooling, as adding them to the matrix/tox env while they’re not installable will cause CI failures unrelated to napari’s 3.10 deprecation.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Czaki Czaki changed the title drop python 3.10 tests on napari repo chore: drop python 3.10 tests on napari repo Jul 13, 2026
@Czaki Czaki added this to the 0.17.1 milestone Jul 13, 2026
@Czaki Czaki changed the title chore: drop python 3.10 tests on napari repo chore: drop python 3.10 tests on napari repository Jul 13, 2026
@Czaki
Czaki merged commit 25e4917 into develop Jul 13, 2026
62 of 68 checks passed
@Czaki
Czaki deleted the update_napari_repo_tests branch July 13, 2026 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant