Fix WebSocket scheme detection for HTTPS deployments - #15
Open
lkirc wants to merge 1 commit into
Open
Conversation
znerol2
added a commit
to dmfdeploy/dmf-media
that referenced
this pull request
Jun 23, 2026
The build-stage mixed-content sed-patch is superseded by upstream fix 3dmedium/nmos_crosspoint#15. Document that the patch RUN block must be deleted (and NMOS_CROSSPOINT_REF bumped) once a ref including #15 is pinned — the fail-closed grep guards will break the build by design until then. Tracked in dmfdeploy/dmfdeploy#129. Signed-off-by: znerol2 <6800371+znerol2@users.noreply.github.com>
github-actions Bot
pushed a commit
to dmfdeploy/dmf-media
that referenced
this pull request
Jun 23, 2026
The build-stage mixed-content sed-patch is superseded by upstream fix 3dmedium/nmos_crosspoint#15. Document that the patch RUN block must be deleted (and NMOS_CROSSPOINT_REF bumped) once a ref including #15 is pinned — the fail-closed grep guards will break the build by design until then. Tracked in dmfdeploy/dmfdeploy#129. Signed-off-by: znerol2 <6800371+znerol2@users.noreply.github.com>
Owner
|
Thanks for reporting, i will try to include this in the next commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix WebSocket URL generation in
ServerConnectorService.tsso the UI works when served over HTTPS behind a TLS-terminating proxy.Root cause
window.location.protocolreturnshttp:orhttps:with a trailing colon, but the existing code compared it tohttp/httpswithout thecolon. That made the condition always false, so the client always built a
ws://URL.When the page is loaded over HTTPS, the browser blocks that as mixed content and the UI stays stuck on “connecting...”.
Fix
Build the WebSocket scheme from
window.location.protocol === 'https:'and usewindow.location.hostso hostname and port are handled consistently.Behavior
wss://...ws://...Verification