Skip to content

test: Small touchups to the framework #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rustaceanrob merged 1 commit into from
Jun 23, 2026
Merged

test: Small touchups to the framework #49

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/test/util/framework.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ class TestContext
private:
std::atomic<int> m_checks{0};
std::atomic<int> m_failed{0};
bool m_did_throw{false};
std::atomic<bool> m_did_throw{false};
const std::string m_full_name;
const std::thread::id m_owner_thread{std::this_thread::get_id()};

Expand Down Expand Up @@ -185,12 +185,12 @@ class TestContext

void exception_occured()
{
m_did_throw = true;
m_did_throw.store(true, std::memory_order_relaxed);
}

bool did_fail()
bool passed()
{
return m_did_throw || m_failed.load(std::memory_order_relaxed) > 0;
return !m_did_throw.load(std::memory_order_relaxed) || m_failed.load(std::memory_order_relaxed) == 0;
}

TestStats stats() const noexcept
Expand Down Expand Up @@ -514,7 +514,7 @@ inline int run(int argc, char** argv)
}
const auto stats = ctx.stats();
summary.total_checks += stats.checks;
if (!ctx.did_fail()) {
if (ctx.passed()) {
++summary.passed;
log(LogLevel::Info, "[ OK ] %s (%d checks)\n", test_case.name, stats.checks);
} else {
Expand Down
Loading