fix(miden-bank): avoid deposit namespace collision - #243
Open
bars26 wants to merge 9 commits into
Open
Conversation
…t note to use renamed method
Updated references from 'account.deposit' to 'account.bank_deposit' in the documentation to reflect changes in the deposit flow.
Updated asset management documentation to reflect changes in deposit functions and added skeleton for withdraw function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames the Miden Bank account method from
deposit()tobank_deposit()to avoid the namespace collision with the deposit note component.Changes
Bank::deposit()method toBank::bank_deposit()withdraw()unchangedThis makes the bank account method explicit while avoiding the
depositnamespace collision between components.