Skip to content

fix(miden-bank): avoid deposit namespace collision - #243

Open
bars26 wants to merge 9 commits into
0xMiden:mainfrom
bars26:fix-miden-bank-namespace-collision
Open

fix(miden-bank): avoid deposit namespace collision#243
bars26 wants to merge 9 commits into
0xMiden:mainfrom
bars26:fix-miden-bank-namespace-collision

Conversation

@bars26

@bars26 bars26 commented Aug 22, 2026

Copy link
Copy Markdown

Summary

Renames the Miden Bank account method from deposit() to bank_deposit() to avoid the namespace collision with the deposit note component.

Changes

  • Renamed the Bank::deposit() method to Bank::bank_deposit()
  • Updated the bank account implementation
  • Updated the deposit-note cross-component call
  • Updated all related Miden Bank tutorial documentation and diagrams
  • Kept withdraw() unchanged

This makes the bank account method explicit while avoiding the deposit namespace collision between components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant