Allow configuring calibration retract angle - #65
Open
unfokus wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We tried to build the project at FAFO and had trouble to achieve good calibration results, despite having a strong magnetic field at the sensor.
It turned out that the selected homing position was too far out, which lead to non-linear encoder readings at the start and end of the homing run. This caused oscillations and buggy behavior, as well as an off-set mid-point.
Patching the calibration routine to retract about 18 degrees after homing perfectly solved our problems. So here is a PR to expose that as a constant in the hw_config file, as it might be useful for others.
In the homing section of the config is a "Not implemented yet" for a const "HOMING_FINISH_POS". What was the plan here? Was this meant as a retract value for all homing calls? If that's the case, I could implement that instead and update the PR.