What & Where?
get_data() method in mml_tensor
Why?
This accessor method was a poor choice from the beginning. The whole point of the tensor is to use it as a data structure without needing to know anything about the underlying implementation. Its bad encapsulation leads developers to compare the underlying data instead of the actual tensors, which is not its intention.
Suggestion
Remove it.
What & Where?
get_data() method in mml_tensor
Why?
This accessor method was a poor choice from the beginning. The whole point of the tensor is to use it as a data structure without needing to know anything about the underlying implementation. Its bad encapsulation leads developers to compare the underlying data instead of the actual tensors, which is not its intention.
Suggestion
Remove it.