diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index f2efe4c..700cf66 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -135,4 +135,5 @@ jobs: tag_name: ${{ steps.gate.outputs.tag }} name: ${{ steps.gate.outputs.tag }} body_path: RELEASE_NOTES.md + generate_release_notes: true files: dist/* diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md index 6c4268f..4973271 100644 --- a/RELEASE_NOTES.md +++ b/RELEASE_NOTES.md @@ -1,5 +1,3 @@ -## v1.2.3 — Patch CLI +## v1.2.4 — Patch CLI `provision` option -- Fix how CLI shows help texts for various options(Formatting) -- Add error for not passing `--name` in `register --oauth`, because API requires it. -- Bump `pyproject.toml` to 5 - Production/Stable State \ No newline at end of file +- Fix `wakemypc provision --server-url ***` displayed missing parameters error when using this option \ No newline at end of file diff --git a/pyproject.toml b/pyproject.toml index b9d9c8c..c2eaf9d 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -1,6 +1,6 @@ [project] name = "wakemypc" -version = "1.2.3" +version = "1.2.4" description = "Companion CLI for https://wakemypc.com (WakeMyPC) -- flash, provision, and manage Pico W transmitters from your terminal. WakeMyPC is a website that lets you turn on you PC remotely from anywhere in the world using Wake-on-Lan." readme = "README.md" license = { file = "LICENSE" } diff --git a/src/wakemypc/main.py b/src/wakemypc/main.py index e96b84b..49d49db 100644 --- a/src/wakemypc/main.py +++ b/src/wakemypc/main.py @@ -495,7 +495,6 @@ def upload(port, firmware_dir, github, version, no_restart, files): @click.option( "--server-url", required=False, - default="https://wakemypc.com", help="URL of your WakeMyPC server (e.g. https://wakemypc.com)", ) @click.option("-a", "--add-new-wifi", required=False, is_flag=True, help="Add new WiFi network instead of replacing existing ones") @@ -570,6 +569,7 @@ def provision(server_url, wifi_ssid, wifi_pass, port, add_new_wifi, clear_wifi, (add_new_wifi and wifi_ssid and wifi_pass) or clear_wifi or (remove_wifi and wifi_ssid) + or server_url ): click.echo("\nMissing required options.\n") click.echo(click.get_current_context().get_help()) @@ -598,6 +598,9 @@ def provision(server_url, wifi_ssid, wifi_pass, port, add_new_wifi, clear_wifi, sys.exit(1) click.echo(f"Provisioning Pico on {port}...") + + if server_url == "": + server_url = "https://wakemypc.com" # default value if user explicitly passed empty string try: result = provision_pico(