Skip to content

llvm.download-ci-llvm = true + assertions = true with unavailable alt CI LLVM shows no warnings/errors, tries to build LLVM #160919

Description

@jieyouxu

Summary

On hosts (e.g. aarch64-apple-darwin) where we don't built "alt CI LLVM" (CI LLVM with assertions enabled), a configuration like

[llvm]
download-ci-llvm = true
assertions = true

will fail to find a CI LLVM from the alternative channel that has "compatible LLVM config" (namely with assertions enabled), yet prints zero warnings/errors, and then tries to checkout llvm submodule and build it locally.

When download-ci-llvm = true, the user intention is to force usage of CI LLVM. We should at least show a warning here, or error, and not silently try to build LLVM.

Command used

./x build library

Expected behaviour

Warning or error for incompatible LLVM config versus available CI LLVM artifacts

Actual behaviour

0 errors 0 warnings

Bootstrap configuration (bootstrap.toml)

[llvm]
download-ci-llvm = true
assertions = true

Operating system

aarch64-apple-darwin host

HEAD

a04c7a0

Additional context

N/A

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-bootstrap-ci-llvmArea: bootstrap CI LLVMC-bugCategory: This is a bug.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions