From 956ff13432491cf8787221d80d7dec938d3f8aa6 Mon Sep 17 00:00:00 2001 From: "Tj (bougyman) Vanderpoel" Date: Sun, 9 Aug 2026 20:16:43 -0400 Subject: [PATCH] fix(ci): skip commit-subject validation in the post-merge pipeline Validate Commit Subjects only makes sense pre-merge (should this PR be mergeable) - by the time main.yaml's validate job runs, the commits are already merged, so re-checking their subjects is meaningless. Test still re-runs post-merge (verifies the actual merge result); commit- subject validation no longer does, via a new skip_commit_validation workflow_call input on ci.yaml. Closes #40. Co-Authored-By: Claude Sonnet 5 --- .github/workflows/ci.yaml | 9 +++++++++ .github/workflows/main.yaml | 2 ++ 2 files changed, 11 insertions(+) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index d90d635..0d80faa 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -4,6 +4,14 @@ name: CI on: # yamllint disable-line rule:truthy workflow_dispatch: workflow_call: + inputs: + skip_commit_validation: + description: >- + Skip the commit-subject check - it only makes sense pre-merge + (should this PR be mergeable), not as a post-merge gate. + required: false + type: boolean + default: false pull_request: jobs: @@ -43,6 +51,7 @@ jobs: run: mix test conventional_commits: + if: inputs.skip_commit_validation != true name: Validate Commit Subjects runs-on: ubuntu-latest steps: diff --git a/.github/workflows/main.yaml b/.github/workflows/main.yaml index 2f7ff6a..71fbd3f 100644 --- a/.github/workflows/main.yaml +++ b/.github/workflows/main.yaml @@ -18,6 +18,8 @@ jobs: validate: name: Validations uses: ./.github/workflows/ci.yaml + with: + skip_commit_validation: true manage-release-pr: needs: [validate]